Bug 90494

Summary: Implement device metrics for blackberry
Product: WebKit Reporter: Hanna <hanma>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kpiascik, mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hanna
Reported 2012-07-03 14:09:41 PDT
enabling remotely changing the size of the viewport on device https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=149876
Attachments
Patch (8.79 KB, patch)
2012-07-04 07:36 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2012-07-04 08:59 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
Patch (5.45 KB, patch)
2012-07-04 11:50 PDT, Hanna 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hanna
Comment 1 2012-07-04 07:36:41 PDT
Created attachment 150792 [details] Patch
Konrad Piascik
Comment 2 2012-07-04 08:05:45 PDT
Comment on attachment 150792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150792&action=review > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h:65 > + OwnPtr<DeviceMetricsSupport> m_deviceMetrics; New member variables should be declared last and initialized in the order they are declared in the header. You're initializing in the correct order in your constructor but not declaring in the right order. > Source/WebKit/blackberry/WebCoreSupport/InspectorDeviceMetrics.h:1 > +/* This is a small class that's entirely declared in the header. This is not good and should be moved into the InspectorClientBlackberry class we don't need a separate class for this functionality.
Hanna
Comment 3 2012-07-04 08:59:25 PDT
Created attachment 150808 [details] Patch
Konrad Piascik
Comment 4 2012-07-04 09:05:06 PDT
Comment on attachment 150808 [details] Patch Looks good.
Rob Buis
Comment 5 2012-07-04 09:53:39 PDT
Comment on attachment 150808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150808&action=review LGTM. > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:93 > +void InspectorClientBlackBerry::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow) fitWindow not used, so you can remove the name.
Hanna
Comment 6 2012-07-04 11:31:50 PDT
(In reply to comment #5) > (From update of attachment 150808 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150808&action=review > > LGTM. > > > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:93 > > +void InspectorClientBlackBerry::overrideDeviceMetrics(int width, int height, float fontScaleFactor, bool fitWindow) > > fitWindow not used, so you can remove the name. This function is called from the front end, I do not know if I remove a parameter it would still recognize the function
Hanna
Comment 7 2012-07-04 11:50:59 PDT
Created attachment 150829 [details] Patch
Rob Buis
Comment 8 2012-07-04 12:35:05 PDT
Comment on attachment 150829 [details] Patch Looks good.
WebKit Review Bot
Comment 9 2012-07-04 15:06:56 PDT
Comment on attachment 150829 [details] Patch Clearing flags on attachment: 150829 Committed r121872: <http://trac.webkit.org/changeset/121872>
WebKit Review Bot
Comment 10 2012-07-04 15:07:01 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 11 2012-07-15 20:40:34 PDT
Comment on attachment 150829 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150829&action=review > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:88 > +bool InspectorClientBlackBerry::canOverrideDeviceMetrics() not const? > Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.cpp:100 > +bool InspectorClientBlackBerry::supportsFrameInstrumentation() ditto
Note You need to log in before you can comment on or make changes to this bug.