Summary: | Autocorrection in blockquotes causes text to break out of quote | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alice Cheng <alice_cheng> | ||||||||||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | adele, enrica, mifenton, webkit.review.bot | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Alice Cheng
2012-07-03 11:48:14 PDT
Created attachment 150660 [details]
Patch
Fixing the problem and made changes to the previous tests to reflect it.
Attachment 150660 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/platform/mac/editing/spelling/..." exit_code: 1
Source/WebCore/editing/SpellingCorrectionCommand.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 150678 [details]
Patch
Fixed the problem and made changes to the previous test to reflect it.
Comment on attachment 150678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150678&action=review You need to have ChangeLog entry both for WebCore and LayoutTests. I'm assuming this is a new test you've added. Run prepare-ChangeLog at the root of your OpenSource tree. > Source/WebCore/editing/SpellingCorrectionCommand.cpp:38 > + Remove this unnecessary line You should also consider changing the title of the bug. It is not very intuitive. Created attachment 150952 [details]
patch
ChangeLog included, and removed the unnecessary new line.
changed the summary (title). Attachment 150952 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 150953 [details]
Patch
Added bug number
Comment on attachment 150953 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150953&action=review Looks good to me. > Source/WebCore/ChangeLog:11 > + SpellingCorrectionCommand uses ReplaceSelectionCommand to replace the misspelled word with the auto-corrected word. Specifically, ReplaceSelectionCommand does a smart copy, where it breaks out of blockquotes. Thus this patch that replaces ReplaceSelectionCommand with InsertTextCommand will fix the problem I would change it to: The fix is to substitute ReplaceSelectionCommand with InserTextCommand. Created attachment 151361 [details]
patch
Fixed ChangeLog according to review comments.
Posting for commit queue.
Created attachment 151363 [details]
patch
Fixed ChangeLog according to review comments
posting for commit queue
Comment on attachment 151363 [details] patch Clearing flags on attachment: 151363 Committed r122176: <http://trac.webkit.org/changeset/122176> This was landed a long time ago. |