| Summary: | [BlackBerry] Enable registerProtocolHandler for Blackberry | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | George Staikos <staikos> |
| Component: | WebKit BlackBerry | Assignee: | George Staikos <staikos> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | gyuyoung.kim, logingx, mifenton, rakuco, tonikitoo, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Attachments: | |||
|
Description
George Staikos
2012-07-02 18:38:57 PDT
Created attachment 150515 [details]
Patch part 1/3 - Enable RegisterProtocolHandler and stub out
Each patch here builds on the previous and I would like to apply them sequentially to avoid churn. Also someone else will be submitting the third patch.
Created attachment 150524 [details]
Part 2/3 - Enable custom scheme handlers, stub, and remove the whitelist for BlackBerry
Comment on attachment 150524 [details]
Part 2/3 - Enable custom scheme handlers, stub, and remove the whitelist for BlackBerry
Typo
Created attachment 150525 [details]
Part 2/3 - Enable custom scheme handlers, stub, and remove the whitelist for BlackBerry
Comment on attachment 150515 [details] Patch part 1/3 - Enable RegisterProtocolHandler and stub out View in context: https://bugs.webkit.org/attachment.cgi?id=150515&action=review LGTM. > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:814 > +void ChromeClientBlackBerry::registerProtocolHandler(const WTF::String&, const WTF::String&, const WTF::String&, const WTF::String&) You probably do not need the WTF prefixes. Comment on attachment 150525 [details]
Part 2/3 - Enable custom scheme handlers, stub, and remove the whitelist for BlackBerry
LGTM.
(In reply to comment #5) > (From update of attachment 150515 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150515&action=review > > LGTM. > > > Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:814 > > +void ChromeClientBlackBerry::registerProtocolHandler(const WTF::String&, const WTF::String&, const WTF::String&, const WTF::String&) > > You probably do not need the WTF prefixes. Will check this in the following patch(es). I believe you're right, though of course it should be harmless. Comment on attachment 150515 [details] Patch part 1/3 - Enable RegisterProtocolHandler and stub out Clearing flags on attachment: 150515 Committed r121773: <http://trac.webkit.org/changeset/121773> Comment on attachment 150525 [details] Part 2/3 - Enable custom scheme handlers, stub, and remove the whitelist for BlackBerry Clearing flags on attachment: 150525 Committed r121774: <http://trac.webkit.org/changeset/121774> All reviewed patches have been landed. Closing bug. Reopening for the rest. Created attachment 152503 [details]
Patch
Comment on attachment 152503 [details] Patch Clearing flags on attachment: 152503 Committed r122832: <http://trac.webkit.org/changeset/122832> All reviewed patches have been landed. Closing bug. I have a question. I land a RegisterProtocolHandlerClient to Modules/protocolhandler today. http://trac.webkit.org/changeset/122810 Don't you need to adjust it as well ? (In reply to comment #15) > I have a question. I land a RegisterProtocolHandlerClient to Modules/protocolhandler today. > http://trac.webkit.org/changeset/122810 > > Don't you need to adjust it as well ? Thanks, Gyuyoung Kim. We saw your two patches for modular and client. I prefer sync them up in other bugs. Anyway, many thanks for your reminder:) (In reply to comment #16) > (In reply to comment #15) > > I have a question. I land a RegisterProtocolHandlerClient to Modules/protocolhandler today. > > http://trac.webkit.org/changeset/122810 > > > > Don't you need to adjust it as well ? > > Thanks, Gyuyoung Kim. We saw your two patches for modular and client. I prefer sync them up in other bugs. Anyway, many thanks for your reminder:) Ok, thanks. |