Bug 90388

Summary:

Web Inspector: [Internal] Make use of the hierarchical InspectorRules in InspectorStyleSheet without exposing through the protocol

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

apavlov, burg, bweinstein, cmarcelo, dglazkov, joepeck, keishi, loislo, macpherson, menard, pfeldman, pmuellr, rik, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

90280

Attachments:

Description	Flags
Patch	none
Patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-06	none

Alexander Pavlov (apavlov)

Reported 2012-07-02 08:46:00 PDT

Patch to follow.

Attachments
Patch (51.35 KB, patch) 2012-07-02 08:50 PDT, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Patch (50.33 KB, patch) 2012-07-03 03:09 PDT, Alexander Pavlov (apavlov)	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-06 (650.74 KB, application/zip) 2012-07-03 04:18 PDT, WebKit Review Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2012-07-02 08:50:05 PDT

Created attachment 150431 [details] Patch

Alexander Pavlov (apavlov)

Comment 2 2012-07-03 03:09:47 PDT

Created attachment 150570 [details] Patch

WebKit Review Bot

Comment 3 2012-07-03 04:18:22 PDT

Comment on attachment 150570 [details] Patch Attachment 150570 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13139127 New failing tests: http/tests/security/mixedContent/filesystem-url-in-iframe.html

WebKit Review Bot

Comment 4 2012-07-03 04:18:26 PDT

Created attachment 150578 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Timothy Hatcher

Comment 5 2012-07-03 08:54:17 PDT

Does this maintain backwards compatibility then?

Alexander Pavlov (apavlov)

Comment 6 2012-07-03 14:27:40 PDT

(In reply to comment #5) > Does this maintain backwards compatibility then? This patch does, provided that clients handle CSSRuleId and CSSStyleId as opaque objects. As you can see, it does not include any Inspector frontend changes.

Pavel Feldman

Comment 7 2012-07-10 10:51:49 PDT

Comment on attachment 150570 [details] Patch Clearing r? from the obsolete patch.

Note You need to log in before you can comment on or make changes to this bug.