Bug 90386

Summary: [GTK] Add WebKitWebView::context-menu-dismissed signal to WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 90449    
Attachments:
Description Flags
Patch
mrobinson: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-08 none

Carlos Garcia Campos
Reported 2012-07-02 08:14:19 PDT
To notify when the default context menu is dimissed.
Attachments
Patch (13.70 KB, patch)
2012-07-02 08:18 PDT, Carlos Garcia Campos 		mrobinson: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (526.13 KB, application/zip)
2012-07-02 13:04 PDT, WebKit Review Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-07-02 08:18:42 PDT
Created attachment 150425 [details] Patch
WebKit Review Bot
Comment 2 2012-07-02 08:20:32 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Review Bot
Comment 3 2012-07-02 13:04:18 PDT
Comment on attachment 150425 [details] Patch Attachment 150425 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13127281 New failing tests: plugins/iframe-shims.html
WebKit Review Bot
Comment 4 2012-07-02 13:04:22 PDT
Created attachment 150464 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Carlos Garcia Campos
Comment 5 2012-07-03 08:44:02 PDT
Committed r121771: <http://trac.webkit.org/changeset/121771>
Note You need to log in before you can comment on or make changes to this bug.