Bug 90380

Summary: [MICRODATA] Build failure in html/HTMLElement.cpp
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: arko, darin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90377    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2012-07-02 05:51:58 PDT 
Turning on the MICRODATA flag causes the following build failure:

/home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp: In member function ‘WebCore::HTMLPropertiesCollection* WebCore::HTMLElement::properties()’:
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp:993:53: error: cannot convert ‘WebCore::HTMLCollection*’ to ‘WebCore::HTMLPropertiesCollection*’ in return
/home/chris/Devel/WebKit/Source/WebCore/html/HTMLElement.cpp:994:1: warning: control reaches end of non-void function [-Wreturn-type]
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/html/HTMLElement.cpp.o] Error 1
Comment 1 Chris Dumez 2012-07-02 05:59:42 PDT 
Created attachment 150407 [details]
Patch
Comment 2 Arko Saha 2012-07-02 06:44:34 PDT 
Hi Christophe,
I have already filed a bug for this error : https://bugs.webkit.org/show_bug.cgi?id=90378. Can we mark this as a duplicate of 90378?
Thanks for pointing out.
Comment 3 Chris Dumez 2012-07-02 06:46:50 PDT 
Ok, done. I failed to notice the existing bug report, sorry.

*** This bug has been marked as a duplicate of bug 90378 ***
Comment 4 Laszlo Gombos 2012-07-08 19:13:59 PDT 
Comment on attachment 150407 [details]
Patch

Marking the patch obsolete as the fix is landed in r121692 to take it out from the review queue.