Bug 90372

Summary: [Qt][WK2] New API tests introduced in r121620 fail
Product: WebKit Reporter: Csaba Osztrogon√°c <ossy>
Component: Tools / TestsAssignee: Noam Rosenthal <noam>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, luiz, menard, noam, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 70236, 84532    
Attachments:
Description Flags
Patch none

Description Csaba Osztrogon√°c 2012-07-02 04:53:59 PDT
FAIL!  : tst_qrawwebview::noBackground1() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]
FAIL!  : tst_qrawwebview::noBackground2() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]
FAIL!  : tst_qrawwebview::noBackground3() 'compareImages(QImage(expectation), image.rgbSwapped(), 5)' returned FALSE. ()
   Loc: [/home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit2/UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp(228)]

Sholdn't we mark them as expected fails? If there are many 
failing tests on the bot, it's so hard to catch new regressions.
Comment 1 Noam Rosenthal 2012-07-02 05:48:37 PDT
Yes, let's mark as expected fails for now and we'll fix those.
Comment 2 Noam Rosenthal 2012-07-02 09:53:02 PDT
Created attachment 150437 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-02 12:12:45 PDT
Comment on attachment 150437 [details]
Patch

Clearing flags on attachment: 150437

Committed r121698: <http://trac.webkit.org/changeset/121698>
Comment 4 WebKit Review Bot 2012-07-02 12:12:50 PDT
All reviewed patches have been landed.  Closing bug.