Bug 90371

Summary: REGRESSION(r121497): It switched off and broke many unittests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, galpeter, jbadics, ojan, ossy, rtoy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 89706    
Attachments:
Description Flags
Patch abarth: review+

Csaba Osztrogonác
Reported 2012-07-02 03:31:49 PDT
-class PortTestCase(unittest.TestCase): +class PortTestCase(object): This change switched off 231 unittest case, I think accidentally. I tried to revert this change, tests run, but I got 22 new failures: ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_all_test_configurations -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 63, in test_all_test_configurations port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_build_path -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py", line 77, in test_build_path self.assert_build_path(options, ['/mock-checkout/Source/WebKit/chromium/out'], '/foo') File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 344, in assert_build_path port = self.make_port(options=options) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_check_build -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 225, in test_check_build port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_check_wdiff -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 229, in test_check_wdiff port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_default_pixel_tests -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 52, in test_default_pixel_tests self.assertEquals(self.make_port().default_pixel_tests(), True) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_default_timeout_ms -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 48, in test_default_timeout_ms self.assertEquals(self.make_port(options=MockOptions(configuration='Release')).default_timeout_ms(), 6000) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_actual -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 215, in test_diff_image__missing_actual port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_both -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 208, in test_diff_image__missing_both port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_diff_image__missing_expected -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 220, in test_diff_image__missing_expected port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_driver_cmd_line -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 73, in test_driver_cmd_line port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_driver_name_option -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py", line 92, in test_driver_name_option self.assertTrue(self.make_port()._path_to_driver().endswith('DumpRenderTree')) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_expectations_files -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 160, in test_expectations_files port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_get_crash_log -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 320, in test_get_crash_log port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_missing_symbol_to_skipped_tests -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 56, in test_missing_symbol_to_skipped_tests port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_operating_system -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py", line 72, in test_operating_system self.assertEqual('mac', self.make_port().operating_system()) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_path_to_image_diff -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py", line 96, in test_path_to_image_diff self.assertEquals(self.make_port()._path_to_image_diff(), '/mock-checkout/out/Release/ImageDiff') File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_test_configuration -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 290, in test_test_configuration port = self.make_port() File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_uses_apache -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 83, in test_uses_apache self.assertTrue(self.make_port()._uses_apache()) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest.test_versions -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py", line 47, in test_versions self.assertTrue(self.make_port().name() in ('chromium-mac-snowleopard', 'chromium-mac-lion', 'chromium-mac-future')) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 63, in make_port return self.port_maker(host, port_name, options=options, config=config, **kwargs) File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_mac.py", line 75, in __init__ assert self._version in self.SUPPORTED_OS_VERSIONS AssertionError ================================================================================ FAILURE: webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_all_test_configurations -------------------------------------------------------------------------------- Traceback (most recent call last): File "/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py", line 80, in test_all_test_configurations TestConfiguration('lucid', 'x86_64', 'release'), AssertionError: set([TestConfig(version='snowleopard', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86_64', build_type='release'), TestConfig(version='lion', architecture='x86', build_type='debug'), TestConfig(version='icecreamsandwich', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86', build_type='release'), TestConfig(version='win7', architecture='x86', build_type='release'), TestConfig(version='xp', architecture='x86', build_type='release'), TestConfig(version='win7', architecture='x86', build_type='debug'), TestConfig(version='icecreamsandwich', architecture='x86', build_type='release'), TestConfig(version='snowleopard', architecture='x86', build_type='release'), TestConfig(version='lion', architecture='x86', build_type='release'), TestConfig(version='lucid', architecture='x86_64', build_type='debug'), TestConfig(version='xp', architecture='x86', build_type='debug')]) != set([TestConfig(version='snowleopard', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86', build_type='debug'), TestConfig(version='leopard', architecture='x86', build_type='release'), TestConfig(version='lucid', architecture='x86_64', build_type='release'), TestConfig(version='lion', architecture='x86', build_type='debug'), TestConfig(version='icecreamsandwich', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86', build_type='release'), TestConfig(version='win7', architecture='x86', build_type='release'), TestConfig(version='lion', architecture='x86', build_type='release'), TestConfig(version='xp', architecture='x86', build_type='release'), TestConfig(version='icecreamsandwich', architecture='x86', build_type='release'), TestConfig(version='snowleopard', architecture='x86', build_type='release'), TestConfig(version='win7', architecture='x86', build_type='debug'), TestConfig(version='lucid', architecture='x86_64', build_type='debug'), TestConfig(version='xp', architecture='x86', build_type='debug'), TestConfig(version='leopard', architecture='x86', build_type='debug')]) -------------------------------------------------------------------------------- Ran 1451 tests in 12.645s FAILED (failures=22, errors=0)
Attachments
Patch (3.36 KB, patch)
2012-07-02 03:50 PDT, Csaba Osztrogonác 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-07-02 03:50:47 PDT
Created attachment 150393 [details] Patch
Adam Barth
Comment 2 2012-07-02 09:26:09 PDT
Comment on attachment 150393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150393&action=review > Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47 > -class PortTestCase(object): > +class PortTestCase(unittest.TestCase): I see. This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
Dirk Pranke
Comment 3 2012-07-02 09:46:55 PDT
Comment on attachment 150393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150393&action=review >> Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47 >> +class PortTestCase(unittest.TestCase): > > I see. This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py Hm. PortTestCase is supposed to derive from unittest.TestCase, so this is good; I had experimented with something else, and I guess that I missed reverting this part, but I'm not sure how I missed that :(.
Dirk Pranke
Comment 4 2012-07-02 12:45:43 PDT
Committed r121701: <http://trac.webkit.org/changeset/121701>
Dirk Pranke
Comment 5 2012-07-02 12:46:20 PDT
(I landed this myself to fix things :) Hope that's okay.
Note You need to log in before you can comment on or make changes to this bug.