Summary: | REGRESSION(r121497): It switched off and broke many unittests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||
Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dpranke, galpeter, jbadics, ojan, ossy, rtoy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 89706 | ||||||
Attachments: |
|
Description
Csaba Osztrogonác
2012-07-02 03:31:49 PDT
Created attachment 150393 [details]
Patch
Comment on attachment 150393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150393&action=review > Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47 > -class PortTestCase(object): > +class PortTestCase(unittest.TestCase): I see. This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py Comment on attachment 150393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150393&action=review >> Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:47 >> +class PortTestCase(unittest.TestCase): > > I see. This is a partial revert of http://trac.webkit.org/changeset/121497/trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py Hm. PortTestCase is supposed to derive from unittest.TestCase, so this is good; I had experimented with something else, and I guess that I missed reverting this part, but I'm not sure how I missed that :(. Committed r121701: <http://trac.webkit.org/changeset/121701> (I landed this myself to fix things :) Hope that's okay. |