| Summary: | [chromium] Create a WebKit::Web* wrapper for the cc animation classes | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | vollick | ||||||||||||||||
| Component: | WebKit Misc. | Assignee: | vollick | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | abarth, dglazkov, fishd, jamesr, keishi, tkent+wkapi, webkit.review.bot | ||||||||||||||||
| Priority: | P2 | ||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||
| Bug Blocks: | 90468 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
vollick
2012-06-29 13:23:55 PDT
Created attachment 150248 [details]
Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Attachment 150248 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebKit/chromium/tests/WebAnimationTest.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit/chromium/tests/WebAnimationCurveTest.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #3) > Attachment 150248 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 > Source/WebKit/chromium/tests/WebAnimationTest.cpp:30: Alphabetical sorting problem. [build/include_order] [4] > Source/WebKit/chromium/tests/WebAnimationCurveTest.cpp:31: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 2 in 11 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This is a style-bot error. It doesn't like it when <public/WebMyClass.h> is first in the includes in the test. Comment on attachment 150248 [details] Patch Attachment 150248 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13117460 Comment on attachment 150248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150248&action=review Looks pretty close! I think the compile error is probably release-only, but still a valid-ish complaint. > Source/Platform/chromium/public/WebAnimationCurve.h:51 > +struct WebFloatKeyframe { one header per top-level type in the WebKit API, sorry - http://trac.webkit.org/wiki/ChromiumWebKitAPI. > Source/WebKit/chromium/src/WebAnimation.cpp:43 > +struct WebAnimationPrivate { > + OwnPtr<CCActiveAnimation> animation; > +}; I think this indirection is not necessary - it's fine to forward declare a WebCore class outside of #if WEBKIT_IMPLEMENTATION and have a WebPrivateOwnPtr<WebCore::Type> for that type, so long as the header does not have any inline functions that try to create/destroy such an object. See WebLayer for instance, it just has a WebPrivatePtr<WebCore::LayerChromium> member. The FooPrivate indirection is useful for when you have additional state you want to store along with the wrapped class. > Source/WebKit/chromium/src/WebAnimation.cpp:46 > +int WebAnimation::iterations() const { return m_private->animation->iterations(); } > +void WebAnimation::setIterations(int n) { m_private->animation->setIterations(n); } nit: I'd prefer that you expand these out, it's more typing but it makes the code a lot more readable IMO. > Source/WebKit/chromium/src/WebAnimation.cpp:57 > +#if WEBKIT_IMPLEMENTATION the .cpp is all WEBKIT_IMPLEMENTATION, no need for a guard here. #if WEBKIT.. should only appear in headers that may be used by both WebKit and non-WebKit code (i.e. public headers) > Source/WebKit/chromium/src/WebAnimation.cpp:70 > + case WebAnimation::WebAnimationTransform: return CCActiveAnimation::Transform; > + case WebAnimation::WebAnimationOpacity: return CCActiveAnimation::Opacity; nit: I would expand out the return statements to their own line, this is a bit hard to read. For enums, we often make sure that the enum values match, add a compile-time check to AssertMatchingEnums.cpp, and then just static_cast<> between the two enum types (http://trac.webkit.org/wiki/ChromiumWebKitAPI, near the bottom) - it's much shorter code and a bit easier to read. > Source/WebKit/chromium/src/WebAnimationCurve.cpp:43 > +struct WebFloatAnimationCurvePrivate { > + OwnPtr<WebCore::CCKeyframedFloatAnimationCurve> curve; > +}; > + > +struct WebTransformAnimationCurvePrivate { > + OwnPtr<WebCore::CCKeyframedTransformAnimationCurve> curve; > +}; probably don't need these wrappers either > Source/WebKit/chromium/src/WebAnimationCurve.cpp:45 > +PassOwnPtr<WebCore::CCTimingFunction> getTimingFunction(WebTimingFunctionType type) this isn't really a getter - maybe createTimingFunction() ? > Source/WebKit/chromium/src/WebAnimationCurve.cpp:48 > + case WebTimingFunctionEase: return WebCore::CCEaseTimingFunction::create(); put return statements on their own lines, please > Source/WebKit/chromium/src/WebAnimationCurve.cpp:54 > + ASSERT_NOT_REACHED(); i think you may still need a return nullptr; statement here to make the compiler happy since ASSERT_NOT_REACHED() is compiled away to nothing in release builds. the compiler will check that we have a case: for every possible value enum value so the assert isn't all that useful > Source/WebKit/chromium/src/WebAnimationCurve.cpp:72 > +#if WEBKIT_IMPLEMENTATION no #if WEBKIT_IMPLEMENTATION in .cpp files > Source/WebKit/chromium/src/WebAnimationCurve.cpp:105 > +#if WEBKIT_IMPLEMENTATION no #if >> Source/WebKit/chromium/tests/WebAnimationCurveTest.cpp:31 >> + > > Alphabetical sorting problem. [build/include_order] [4] I think the style bot is actually correct here - you should sort all the includes (<public/... and "cc/..." together, and I'm pretty sure the <public/WebTran...> includes will sort below the "cc/..." ones >> Source/WebKit/chromium/tests/WebAnimationTest.cpp:30 >> + > > Alphabetical sorting problem. [build/include_order] [4] same here - <public/WebAnimationCurve.h> should be sorted below "cc/CCActiveAnimation.h" Created attachment 150289 [details] Patch (In reply to comment #6) > (From update of attachment 150248 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150248&action=review > > Looks pretty close! I think the compile error is probably release-only, but still a valid-ish complaint. > > > Source/Platform/chromium/public/WebAnimationCurve.h:51 > > +struct WebFloatKeyframe { > > one header per top-level type in the WebKit API, sorry - http://trac.webkit.org/wiki/ChromiumWebKitAPI. Fixed. > > > Source/WebKit/chromium/src/WebAnimation.cpp:43 > > +struct WebAnimationPrivate { > > + OwnPtr<CCActiveAnimation> animation; > > +}; > > I think this indirection is not necessary - it's fine to forward declare a WebCore class outside of #if WEBKIT_IMPLEMENTATION and have a WebPrivateOwnPtr<WebCore::Type> for that type, so long as the header does not have any inline functions that try to create/destroy such an object. See WebLayer for instance, it just has a WebPrivatePtr<WebCore::LayerChromium> member. The FooPrivate indirection is useful for when you have additional state you want to store along with the wrapped class. Sweet. Removed. > > > Source/WebKit/chromium/src/WebAnimation.cpp:46 > > +int WebAnimation::iterations() const { return m_private->animation->iterations(); } > > +void WebAnimation::setIterations(int n) { m_private->animation->setIterations(n); } > > nit: I'd prefer that you expand these out, it's more typing but it makes the code a lot more readable IMO. Done. > > > Source/WebKit/chromium/src/WebAnimation.cpp:57 > > +#if WEBKIT_IMPLEMENTATION > > the .cpp is all WEBKIT_IMPLEMENTATION, no need for a guard here. #if WEBKIT.. should only appear in headers that may be used by both WebKit and non-WebKit code (i.e. public headers) Removed. > > > Source/WebKit/chromium/src/WebAnimation.cpp:70 > > + case WebAnimation::WebAnimationTransform: return CCActiveAnimation::Transform; > > + case WebAnimation::WebAnimationOpacity: return CCActiveAnimation::Opacity; > > nit: I would expand out the return statements to their own line, this is a bit hard to read. This is gone now due to the the next point. > > For enums, we often make sure that the enum values match, add a compile-time check to AssertMatchingEnums.cpp, and then just static_cast<> between the two enum types (http://trac.webkit.org/wiki/ChromiumWebKitAPI, near the bottom) - it's much shorter code and a bit easier to read. Done. > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:43 > > +struct WebFloatAnimationCurvePrivate { > > + OwnPtr<WebCore::CCKeyframedFloatAnimationCurve> curve; > > +}; > > + > > +struct WebTransformAnimationCurvePrivate { > > + OwnPtr<WebCore::CCKeyframedTransformAnimationCurve> curve; > > +}; > > probably don't need these wrappers either Removed. > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:45 > > +PassOwnPtr<WebCore::CCTimingFunction> getTimingFunction(WebTimingFunctionType type) > > this isn't really a getter - maybe createTimingFunction() ? Done (and moved somewhere visible by both the float and keyframe animation curves). > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:48 > > + case WebTimingFunctionEase: return WebCore::CCEaseTimingFunction::create(); > > put return statements on their own lines, please Done. > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:54 > > + ASSERT_NOT_REACHED(); > > i think you may still need a return nullptr; statement here to make the compiler happy since ASSERT_NOT_REACHED() is compiled away to nothing in release builds. Done. > > the compiler will check that we have a case: for every possible value enum value so the assert isn't all that useful Removed. > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:72 > > +#if WEBKIT_IMPLEMENTATION > > no #if WEBKIT_IMPLEMENTATION in .cpp files Removed. > > > Source/WebKit/chromium/src/WebAnimationCurve.cpp:105 > > +#if WEBKIT_IMPLEMENTATION > > no #if Removed. > > >> Source/WebKit/chromium/tests/WebAnimationCurveTest.cpp:31 > >> + > > > > Alphabetical sorting problem. [build/include_order] [4] > > I think the style bot is actually correct here - you should sort all the includes (<public/... and "cc/..." together, and I'm pretty sure the <public/WebTran...> includes will sort below the "cc/..." ones Whoops -- I remembered there being a problem before, and just assumed it was the same thing. Switched. > > >> Source/WebKit/chromium/tests/WebAnimationTest.cpp:30 > >> + > > > > Alphabetical sorting problem. [build/include_order] [4] > > same here - <public/WebAnimationCurve.h> should be sorted below "cc/CCActiveAnimation.h" Fixed. Comment on attachment 150289 [details] Patch Attachment 150289 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13111607 Created attachment 150315 [details]
Patch
It looks like you can't use stuff in WEBKIT_IMPLEMENTATION blocks in unit tests.
Comment on attachment 150315 [details] Patch Attachment 150315 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13118596 Created attachment 150319 [details]
Patch
Was still using code hidden in WEBKIT_IMPLEMENTATION blocks. Should hopefully be fixed now.
Comment on attachment 150319 [details] Patch Attachment 150319 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13111729 Created attachment 150322 [details]
Patch
Another attempt at appeasing the bots.
Comment on attachment 150322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150322&action=review > Source/Platform/chromium/public/WebTimingFunctionType.h:30 > +enum WebTimingFunctionType { I don't think this enum really stands on its own - when you know it's part of an animation system it makes sense, but as just a standalone header in the Platform APi it seems odd. It looks like it's only used in subclasses of WebAnimationCurve, could this perhaps be an enum in this class? Created attachment 150345 [details] Patch (In reply to comment #14) > (From update of attachment 150322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150322&action=review > > > Source/Platform/chromium/public/WebTimingFunctionType.h:30 > > +enum WebTimingFunctionType { > > I don't think this enum really stands on its own - when you know it's part of an animation system it makes sense, but as just a standalone header in the Platform APi it seems odd. It looks like it's only used in subclasses of WebAnimationCurve, could this perhaps be an enum in this class? Sounds good -- done. Comment on attachment 150345 [details]
Patch
Great! R=me and bombs away
Comment on attachment 150345 [details] Patch Clearing flags on attachment: 150345 Committed r121650: <http://trac.webkit.org/changeset/121650> All reviewed patches have been landed. Closing bug. Reverted r121650 for reason: runhooks is failing for chromium win bots and WebAnimationTest.DefaultSettings is crashing Committed r121655: <http://trac.webkit.org/changeset/121655> (In reply to comment #19) > Reverted r121650 for reason: > > runhooks is failing for chromium win bots and WebAnimationTest.DefaultSettings is crashing > > Committed r121655: <http://trac.webkit.org/changeset/121655> Here is the log for runhooks (view as text) gclient runhooks in dir C:\b\build\slave\webkit-win-latest-rel\build (timeout 300 secs) watching logfiles {} argv: ['gclient', 'runhooks'] environment: APPDATA=C:\Users\chrome-bot\AppData\Roaming CHROME_HEADLESS=1 COMPUTERNAME=BUILD20-M1 COMSPEC=C:\Windows\system32\cmd.exe DEPOT_TOOLS_UPDATE=0 GYP_DEFINES= component=static_library GYP_GENERATOR_FLAGS= msvs_error_on_missing_sources=1 GYP_MSVS_VERSION=2010 HOMEDRIVE=C: HOMEPATH=\Users\chrome-bot LOCALAPPDATA=C:\Users\chrome-bot\AppData\Local LOGNAME=chrome-bot NUMBER_OF_PROCESSORS=16 OS=Windows_NT PATH=C:\b\depot_tools;C:\b\depot_tools\python_bin;C:\Windows\system32;C:\Windows\system32\WBEM;C:\b\build_internal\tools PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC PROCESSOR_ARCHITECTURE=x86 PROCESSOR_ARCHITEW6432=AMD64 PROGRAMFILES=C:\Program Files (x86) PROGRAMW6432=C:\Program Files PWD=C:\b\build\slave\webkit-win-latest-rel\build PYTHONPATH=C:\b\build\site_config;C:\b\build\scripts;C:\b\build\scripts\release;C:\b\build\third_party;C:\b\build_internal\site_config;C:\b\build_internal\symsrc;C:\b\build\slave;C:\b\build\third_party\buildbot_7_12;C:\b\build\third_party\twisted_8_1; SYSTEMDRIVE=C: SYSTEMROOT=C:\Windows TEMP=C:\Users\CHROME~1\AppData\Local\Temp\1 TMP=C:\Users\CHROME~1\AppData\Local\Temp\1 USERDOMAIN=GOLO USERNAME=chrome-bot USERPROFILE=C:\Users\chrome-bot VS100COMNTOOLS=c:\Program Files (x86)\Microsoft Visual Studio 10.0\Common7\Tools\ WINDIR=C:\Windows closing stdin using PTY: False ________ running 'C:\b\depot_tools\python_bin\python.exe src/build/download_nacl_toolchains.py --no-arm-trusted --optional-pnacl --pnacl-version 9044 --file-hash pnacl_linux_x86_32 e8cfbe1ec6e56594a705a8cbb85ba4f2e6a15cbd --file-hash pnacl_linux_x86_64 3ccf6a31f97a5ea779fc08e4150725cacb7204dc --file-hash pnacl_translator 43a6a7469d679f21263aa1f9b99bf0aa8fa64c1f --file-hash pnacl_mac_x86_32 45e0c17aeedb747797a5ff2ef50f3444384d232e --file-hash pnacl_win_x86_32 c0ba23e5a40c89cb1555eabbf9439840e208ea67 --x86-version 8953 --file-hash mac_x86_newlib bc203d116aefbbe38e547f344be6c5b0ab4ce650 --file-hash win_x86_newlib fb74e29baef7185e302a86685a9e61a24cb4ac13 --file-hash linux_x86_newlib 4cbdc174e3d179eb354e52f5021595a8ee3ee5be --file-hash mac_x86 01088800f6e9b1655e937826d26260631141dd78 --file-hash win_x86 2dfdac268b8c32380483361e47399dcea8f0af0e --file-hash linux_x86 114e0c2fbe33adc887377b4121c2e25c17404a9e --save-downloads-dir src/native_client_sdk/src/build_tools/toolchain_archives --keep' in 'C:\b\build\slave\webkit-win-latest-rel\build' C:\b\build\slave\webkit-win-latest-rel\build\src\native_client\toolchain\.tars\toolchain_win_x86.tar.bz2 is already up to date. win_x86: already up to date. C:\b\build\slave\webkit-win-latest-rel\build\src\native_client\toolchain\.tars\naclsdk_win_x86.tgz is already up to date. win_x86_newlib: already up to date. ________ running 'C:\b\depot_tools\python_bin\python.exe src/tools/clang/scripts/update.py --mac-only' in 'C:\b\build\slave\webkit-win-latest-rel\build' ________ running 'C:\b\depot_tools\python_bin\python.exe src/build/win/setup_cygwin_mount.py --win-only' in 'C:\b\build\slave\webkit-win-latest-rel\build' ________ running 'C:\b\depot_tools\python_bin\python.exe src/build/util/lastchange.py -o src/build/util/LASTCHANGE' in 'C:\b\build\slave\webkit-win-latest-rel\build' ________ running 'C:\b\depot_tools\python_bin\python.exe src/build/gyp_chromium' in 'C:\b\build\slave\webkit-win-latest-rel\build' Enabled Psyco JIT. Updating projects from gyp files... Traceback (most recent call last): File "src/build/gyp_chromium", line 173, in <module> sys.exit(gyp.main(args)) File "C:\b\build\slave\webkit-win-latest-rel\build\src\tools\gyp\pylib\gyp\__init__.py", line 480, in main generator.GenerateOutput(flat_list, targets, data, params) File "C:\b\build\slave\webkit-win-latest-rel\build\src\tools\gyp\pylib\gyp\generator\msvs.py", line 1830, in GenerateOutput raise Exception(error_message) Exception: Missing input files: src\third_party\WebKit\Source\Platform\Platform.gyp\..\chromium\public\WebAnimation.hchromium\public\WebAnimationCurve.h Error: Command C:\b\depot_tools\python_bin\python.exe src/build/gyp_chromium returned non-zero exit status 1 in C:\b\build\slave\webkit-win-latest-rel\build program finished with exit code 2 elapsedTime=49.281000 Here is the log for webkit_unit_tests (view as text) python ../../../scripts/slave/runtest.py --target Release --build-dir src/build --build-properties={"blamelist":"jamesr@google.com","branch":"trunk","buildername":"Webkit Linux 32","buildnumber":"20432","got_revision":"145117","mastername":"chromium.webkit","parentname":"","parentslavename":"","revision":"121651","scheduler":"s6_webkit_rel","slavename":"vm59-m1"} --factory-properties={"archive_webkit_results":true,"gclient_env":{"DEPOT_TOOLS_UPDATE":"0","GYP_DEFINES":" component=static_library","GYP_GENERATOR_FLAGS":""},"test_results_server":"test-results.appspot.com","webkit_dir":"third_party/WebKit/Source"} webkit_unit_tests --gtest_print_time in dir /mnt/data/b/build/slave/Webkit_Linux_32/build (timeout 600 secs) watching logfiles {} argv: ['python', '../../../scripts/slave/runtest.py', '--target', 'Release', '--build-dir', 'src/build', u'--build-properties={"blamelist":"jamesr@google.com","branch":"trunk","buildername":"Webkit Linux 32","buildnumber":"20432","got_revision":"145117","mastername":"chromium.webkit","parentname":"","parentslavename":"","revision":"121651","scheduler":"s6_webkit_rel","slavename":"vm59-m1"}', '--factory-properties={"archive_webkit_results":true,"gclient_env":{"DEPOT_TOOLS_UPDATE":"0","GYP_DEFINES":" component=static_library","GYP_GENERATOR_FLAGS":""},"test_results_server":"test-results.appspot.com","webkit_dir":"third_party/WebKit/Source"}', 'webkit_unit_tests', '--gtest_print_time'] environment: CHROME_HEADLESS=1 DISPLAY=:0.0 HOME=/home/chrome-bot LANG=en_US.UTF-8 LOGNAME=chrome-bot PAGER=cat PATH=/mnt/data/b/depot_tools:/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin PWD=/mnt/data/b/build/slave/Webkit_Linux_32/build PYTHONPATH=/mnt/data/b/build/site_config:/mnt/data/b/build/scripts:/mnt/data/b/build/scripts/release:/mnt/data/b/build/third_party:/mnt/data/b/build_internal/site_config:/mnt/data/b/build_internal/symsrc:/mnt/data/b/build/slave:/mnt/data/b/build/third_party/buildbot_7_12:/mnt/data/b/build/third_party/twisted_8_1: SHELL=/bin/bash USER=chrome-bot closing stdin using PTY: True [Running on builder: "None"] Disabling sandbox. Setting environment variable: CHROME_DEVEL_SANDBOX="" Verifying Xvfb is not running ... Verifying Xvfb has started... xdisplaycheck succeeded after 0 seconds. xdisplaycheck output: > Connected after 0 retries ...OK Window manager (icewm) started. /mnt/data/b/build/slave/Webkit_Linux_32/build/src/build/../sconsbuild/Release/webkit_unit_tests --gtest_print_time [==========] Running 1039 tests from 288 test cases. [----------] Global test environment set-up. [----------] 4 tests from RenderTableRowDeathTest [ RUN ] RenderTableRowDeathTest.CanSetRow [25999:25999:0701/200737:756153634:WARNING:test_suite.cc(97)] AtExitManager: items were added to the callback list by RenderTableRowDeathTest.CanSetRow. Global state should be cleaned up before a test exits. [ OK ] RenderTableRowDeathTest.CanSetRow (3 ms) [ RUN ] RenderTableRowDeathTest.CanSetRowToMaxRowIndex [ OK ] RenderTableRowDeathTest.CanSetRowToMaxRowIndex (0 ms) [ RUN ] RenderTableRowDeathTest.CrashIfRowOverflowOnSetting [WARNING] testing/gtest/src/gtest-death-test.cc:827:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. [ OK ] RenderTableRowDeathTest.CrashIfRowOverflowOnSetting (28 ms) [ RUN ] RenderTableRowDeathTest.CrashIfSettingUnsetRowIndex [WARNING] testing/gtest/src/gtest-death-test.cc:827:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. [ OK ] RenderTableRowDeathTest.CrashIfSettingUnsetRowIndex (27 ms) [----------] 4 tests from RenderTableRowDeathTest (59 ms total) [----------] 4 tests from RenderTableCellDeathTest [ RUN ] RenderTableCellDeathTest.CanSetColumn [ OK ] RenderTableCellDeathTest.CanSetColumn (1 ms) [ RUN ] RenderTableCellDeathTest.CanSetColumnToMaxColumnIndex [ OK ] RenderTableCellDeathTest.CanSetColumnToMaxColumnIndex (0 ms) [ RUN ] RenderTableCellDeathTest.CrashIfColumnOverflowOnSetting [WARNING] testing/gtest/src/gtest-death-test.cc:827:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. [ OK ] RenderTableCellDeathTest.CrashIfColumnOverflowOnSetting (27 ms) [ RUN ] RenderTableCellDeathTest.CrashIfSettingUnsetColumnIndex [WARNING] testing/gtest/src/gtest-death-test.cc:827:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. [ OK ] RenderTableCellDeathTest.CrashIfSettingUnsetColumnIndex (27 ms) [----------] 4 tests from RenderTableCellDeathTest (55 ms total) [----------] 3 tests from WebInputEventFactoryTest [ RUN ] WebInputEventFactoryTest.DoubleClick [ OK ] WebInputEventFactoryTest.DoubleClick (2 ms) [ RUN ] WebInputEventFactoryTest.MouseUpClickCount [ OK ] WebInputEventFactoryTest.MouseUpClickCount (0 ms) [ RUN ] WebInputEventFactoryTest.NumPadConversion [ OK ] WebInputEventFactoryTest.NumPadConversion (0 ms) [----------] 3 tests from WebInputEventFactoryTest (2 ms total) [----------] 3 tests from ScrollAnimatorEnabled [ RUN ] ScrollAnimatorEnabled.Enabled [25999:25999:0701/200737:756266720:WARNING:test_suite.cc(97)] AtExitManager: items were added to the callback list by ScrollAnimatorEnabled.Enabled. Global state should be cleaned up before a test exits. [ OK ] ScrollAnimatorEnabled.Enabled (0 ms) [ RUN ] ScrollAnimatorEnabled.flingScrollEncoding [ OK ] ScrollAnimatorEnabled.flingScrollEncoding (0 ms) [ RUN ] ScrollAnimatorEnabled.Disabled [ OK ] ScrollAnimatorEnabled.Disabled (0 ms) [----------] 3 tests from ScrollAnimatorEnabled (1 ms total) [----------] 34 tests from ScrollAnimatorNoneTest [ RUN ] ScrollAnimatorNoneTest.CurveMathLinear [ OK ] ScrollAnimatorNoneTest.CurveMathLinear (0 ms) [ RUN ] ScrollAnimatorNoneTest.CurveMathQuadratic [ OK ] ScrollAnimatorNoneTest.CurveMathQuadratic (0 ms) [ RUN ] ScrollAnimatorNoneTest.CurveMathCubic [ OK ] ScrollAnimatorNoneTest.CurveMathCubic (0 ms) [ RUN ] ScrollAnimatorNoneTest.CurveMathQuartic [ OK ] ScrollAnimatorNoneTest.CurveMathQuartic (1 ms) [ RUN ] ScrollAnimatorNoneTest.CurveMathBounce [ OK ] ScrollAnimatorNoneTest.CurveMathBounce (0 ms) [ RUN ] ScrollAnimatorNoneTest.CurveMathCoast [ OK ] ScrollAnimatorNoneTest.CurveMathCoast (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollOnceLinear [ OK ] ScrollAnimatorNoneTest.ScrollOnceLinear (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollOnceQuadratic [ OK ] ScrollAnimatorNoneTest.ScrollOnceQuadratic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollLongQuadratic [ OK ] ScrollAnimatorNoneTest.ScrollLongQuadratic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollQuadraticNoSustain [ OK ] ScrollAnimatorNoneTest.ScrollQuadraticNoSustain (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollQuadraticSmoothed [ OK ] ScrollAnimatorNoneTest.ScrollQuadraticSmoothed (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollOnceCubic [ OK ] ScrollAnimatorNoneTest.ScrollOnceCubic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollOnceQuartic [ OK ] ScrollAnimatorNoneTest.ScrollOnceQuartic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollOnceShort [ OK ] ScrollAnimatorNoneTest.ScrollOnceShort (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollTwiceQuadratic [ OK ] ScrollAnimatorNoneTest.ScrollTwiceQuadratic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollLotsQuadratic [ OK ] ScrollAnimatorNoneTest.ScrollLotsQuadratic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollLotsQuadraticSmoothed [ OK ] ScrollAnimatorNoneTest.ScrollLotsQuadraticSmoothed (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollTwiceCubic [ OK ] ScrollAnimatorNoneTest.ScrollTwiceCubic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollLotsCubic [ OK ] ScrollAnimatorNoneTest.ScrollLotsCubic (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollLotsCubicSmoothed [ OK ] ScrollAnimatorNoneTest.ScrollLotsCubicSmoothed (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollWheelTrace [ OK ] ScrollAnimatorNoneTest.ScrollWheelTrace (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollWheelTraceSmoothed [ OK ] ScrollAnimatorNoneTest.ScrollWheelTraceSmoothed (0 ms) [ RUN ] ScrollAnimatorNoneTest.LinuxTrackPadTrace [ OK ] ScrollAnimatorNoneTest.LinuxTrackPadTrace (0 ms) [ RUN ] ScrollAnimatorNoneTest.LinuxTrackPadTraceSmoothed [ OK ] ScrollAnimatorNoneTest.LinuxTrackPadTraceSmoothed (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollDownToBumper [ OK ] ScrollAnimatorNoneTest.ScrollDownToBumper (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollUpToBumper [ OK ] ScrollAnimatorNoneTest.ScrollUpToBumper (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollUpToBumperCoast [ OK ] ScrollAnimatorNoneTest.ScrollUpToBumperCoast (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollDownToBumperCoast [ OK ] ScrollAnimatorNoneTest.ScrollDownToBumperCoast (0 ms) [ RUN ] ScrollAnimatorNoneTest.VaryingInputsEquivalency [ OK ] ScrollAnimatorNoneTest.VaryingInputsEquivalency (0 ms) [ RUN ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoast [ OK ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoast (0 ms) [ RUN ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoastLarge [ OK ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoastLarge (0 ms) [ RUN ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoastSteep [ OK ] ScrollAnimatorNoneTest.VaryingInputsEquivalencyCoastSteep (0 ms) [ RUN ] ScrollAnimatorNoneTest.ScrollStopInMiddle [ OK ] ScrollAnimatorNoneTest.ScrollStopInMiddle (0 ms) [ RUN ] ScrollAnimatorNoneTest.ReverseInMiddle [ OK ] ScrollAnimatorNoneTest.ReverseInMiddle (0 ms) [----------] 34 tests from ScrollAnimatorNoneTest (2 ms total) [----------] 9 tests from WebViewTest [ RUN ] WebViewTest.FocusIsInactive [ OK ] WebViewTest.FocusIsInactive (15 ms) [ RUN ] WebViewTest.ActiveState [ OK ] WebViewTest.ActiveState (1 ms) [ RUN ] WebViewTest.AutoResizeMinimumSize [25999:25999:0701/200737:756297549:WARNING:test_suite.cc(97)] AtExitManager: items were added to the callback list by WebViewTest.AutoResizeMinimumSize. Global state should be cleaned up before a test exits. [ OK ] WebViewTest.AutoResizeMinimumSize (12 ms) [ RUN ] WebViewTest.AutoResizeHeightOverflowAndFixedWidth [ OK ] WebViewTest.AutoResizeHeightOverflowAndFixedWidth (6 ms) [ RUN ] WebViewTest.AutoResizeFixedHeightAndWidthOverflow [ OK ] WebViewTest.AutoResizeFixedHeightAndWidthOverflow (6 ms) [ RUN ] WebViewTest.AutoResizeInBetweenSizes [ OK ] WebViewTest.AutoResizeInBetweenSizes (5 ms) [ RUN ] WebViewTest.AutoResizeOverflowSizes [ OK ] WebViewTest.AutoResizeOverflowSizes (7 ms) [ RUN ] WebViewTest.AutoResizeMaxSize [ OK ] WebViewTest.AutoResizeMaxSize (5 ms) [ RUN ] WebViewTest.SetEditableSelectionOffsetsAndTextInputInfo [ OK ] WebViewTest.SetEditableSelectionOffsetsAndTextInputInfo (34 ms) [----------] 9 tests from WebViewTest (91 ms total) [----------] 1 test from WebURLResponseTest [ RUN ] WebURLResponseTest.ExtraData [ OK ] WebURLResponseTest.ExtraData (0 ms) [----------] 1 test from WebURLResponseTest (0 ms total) [----------] 1 test from WebURLRequestTest [ RUN ] WebURLRequestTest.ExtraData [ OK ] WebURLRequestTest.ExtraData (0 ms) [----------] 1 test from WebURLRequestTest (0 ms total) [----------] 13 tests from WebTransformOperationTest [ RUN ] WebTransformOperationTest.transformTypesAreUnique [ OK ] WebTransformOperationTest.transformTypesAreUnique (0 ms) [ RUN ] WebTransformOperationTest.matchTypesSameLength [ OK ] WebTransformOperationTest.matchTypesSameLength (0 ms) [ RUN ] WebTransformOperationTest.matchTypesDifferentLength [ OK ] WebTransformOperationTest.matchTypesDifferentLength (0 ms) [ RUN ] WebTransformOperationTest.applyTranslate [ OK ] WebTransformOperationTest.applyTranslate (0 ms) [ RUN ] WebTransformOperationTest.applyRotate [ OK ] WebTransformOperationTest.applyRotate (0 ms) [ RUN ] WebTransformOperationTest.applyScale [ OK ] WebTransformOperationTest.applyScale (0 ms) [ RUN ] WebTransformOperationTest.applySkew [ OK ] WebTransformOperationTest.applySkew (0 ms) [ RUN ] WebTransformOperationTest.applyPerspective [ OK ] WebTransformOperationTest.applyPerspective (0 ms) [ RUN ] WebTransformOperationTest.applyMatrix [ OK ] WebTransformOperationTest.applyMatrix (0 ms) [ RUN ] WebTransformOperationTest.applyOrder [ OK ] WebTransformOperationTest.applyOrder (0 ms) [ RUN ] WebTransformOperationTest.blendOrder [ OK ] WebTransformOperationTest.blendOrder (0 ms) [ RUN ] WebTransformOperationTest.blendProgress [ OK ] WebTransformOperationTest.blendProgress (0 ms) [ RUN ] WebTransformOperationTest.blendWhenTypesDoNotMatch [ OK ] WebTransformOperationTest.blendWhenTypesDoNotMatch (0 ms) [----------] 13 tests from WebTransformOperationTest (0 ms total) [----------] 39 tests from WebTransformationMatrixTest [ RUN ] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix [ OK ] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix (0 ms) [ RUN ] WebTransformationMatrixTest.verifyConstructorFor2dElements [ OK ] WebTransformationMatrixTest.verifyConstructorFor2dElements (0 ms) [ RUN ] WebTransformationMatrixTest.verifyConstructorForAllElements [ OK ] WebTransformationMatrixTest.verifyConstructorForAllElements (0 ms) [ RUN ] WebTransformationMatrixTest.verifyCopyConstructor [ OK ] WebTransformationMatrixTest.verifyCopyConstructor (0 ms) [ RUN ] WebTransformationMatrixTest.verifyMatrixInversion [ OK ] WebTransformationMatrixTest.verifyMatrixInversion (0 ms) [ RUN ] WebTransformationMatrixTest.verifyTo2DTransform [ OK ] WebTransformationMatrixTest.verifyTo2DTransform (0 ms) [ RUN ] WebTransformationMatrixTest.verifyAssignmentOperator [ OK ] WebTransformationMatrixTest.verifyAssignmentOperator (0 ms) [ RUN ] WebTransformationMatrixTest.verifyEqualsBooleanOperator [ OK ] WebTransformationMatrixTest.verifyEqualsBooleanOperator (1 ms) [ RUN ] WebTransformationMatrixTest.verifyMultiplyOperator [ OK ] WebTransformationMatrixTest.verifyMultiplyOperator (0 ms) [ RUN ] WebTransformationMatrixTest.verifyMatrixMultiplication [ OK ] WebTransformationMatrixTest.verifyMatrixMultiplication (0 ms) [ RUN ] WebTransformationMatrixTest.verifyMakeIdentiy [ OK ] WebTransformationMatrixTest.verifyMakeIdentiy (0 ms) [ RUN ] WebTransformationMatrixTest.verifyTranslate [ OK ] WebTransformationMatrixTest.verifyTranslate (0 ms) [ RUN ] WebTransformationMatrixTest.verifyTranslate3d [ OK ] WebTransformationMatrixTest.verifyTranslate3d (0 ms) [ RUN ] WebTransformationMatrixTest.verifyTranslateRight3d [ OK ] WebTransformationMatrixTest.verifyTranslateRight3d (0 ms) [ RUN ] WebTransformationMatrixTest.verifyScale [ OK ] WebTransformationMatrixTest.verifyScale (0 ms) [ RUN ] WebTransformationMatrixTest.verifyNonUniformScale [ OK ] WebTransformationMatrixTest.verifyNonUniformScale (0 ms) [ RUN ] WebTransformationMatrixTest.verifyScale3d [ OK ] WebTransformationMatrixTest.verifyScale3d (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotate [ OK ] WebTransformationMatrixTest.verifyRotate (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotate3d [ OK ] WebTransformationMatrixTest.verifyRotate3d (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotate3dOrderOfCompositeRotations [ OK ] WebTransformationMatrixTest.verifyRotate3dOrderOfCompositeRotations (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotateAxisAngle3d [ OK ] WebTransformationMatrixTest.verifyRotateAxisAngle3d (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotateAxisAngle3dForArbitraryAxis [ OK ] WebTransformationMatrixTest.verifyRotateAxisAngle3dForArbitraryAxis (0 ms) [ RUN ] WebTransformationMatrixTest.verifyRotateAxisAngle3dForDegenerateAxis [ OK ] WebTransformationMatrixTest.verifyRotateAxisAngle3dForDegenerateAxis (0 ms) [ RUN ] WebTransformationMatrixTest.verifySkewX [ OK ] WebTransformationMatrixTest.verifySkewX (0 ms) [ RUN ] WebTransformationMatrixTest.verifySkewY [ OK ] WebTransformationMatrixTest.verifySkewY (0 ms) [ RUN ] WebTransformationMatrixTest.verifyApplyPerspective [ OK ] WebTransformationMatrixTest.verifyApplyPerspective (0 ms) [ RUN ] WebTransformationMatrixTest.verifyHasPerspective [ OK ] WebTransformationMatrixTest.verifyHasPerspective (0 ms) [ RUN ] WebTransformationMatrixTest.verifyIsInvertible [ OK ] WebTransformationMatrixTest.verifyIsInvertible (0 ms) [ RUN ] WebTransformationMatrixTest.verifyIsIdentity [ OK ] WebTransformationMatrixTest.verifyIsIdentity (0 ms) [ RUN ] WebTransformationMatrixTest.verifyIsIdentityOrTranslation [ OK ] WebTransformationMatrixTest.verifyIsIdentityOrTranslation (0 ms) [ RUN ] WebTransformationMatrixTest.verifyIsIntegerTranslation [ OK ] WebTransformationMatrixTest.verifyIsIntegerTranslation (2 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForTranslation [ OK ] WebTransformationMatrixTest.verifyBlendForTranslation (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForScale [ OK ] WebTransformationMatrixTest.verifyBlendForScale (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForSkewX [ OK ] WebTransformationMatrixTest.verifyBlendForSkewX (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForSkewY [ OK ] WebTransformationMatrixTest.verifyBlendForSkewY (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForRotationAboutX [ OK ] WebTransformationMatrixTest.verifyBlendForRotationAboutX (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForRotationAboutY [ OK ] WebTransformationMatrixTest.verifyBlendForRotationAboutY (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForRotationAboutZ [ OK ] WebTransformationMatrixTest.verifyBlendForRotationAboutZ (0 ms) [ RUN ] WebTransformationMatrixTest.verifyBlendForCompositeTransform [ OK ] WebTransformationMatrixTest.verifyBlendForCompositeTransform (0 ms) [----------] 39 tests from WebTransformationMatrixTest (4 ms total) [----------] 13 tests from WebTransformAnimationCurveTest [ RUN ] WebTransformAnimationCurveTest.OneTransformKeyframe [ OK ] WebTransformAnimationCurveTest.OneTransformKeyframe (0 ms) [ RUN ] WebTransformAnimationCurveTest.TwoTransformKeyframe [ OK ] WebTransformAnimationCurveTest.TwoTransformKeyframe (0 ms) [ RUN ] WebTransformAnimationCurveTest.ThreeTransformKeyframe [ OK ] WebTransformAnimationCurveTest.ThreeTransformKeyframe (0 ms) [ RUN ] WebTransformAnimationCurveTest.RepeatedTransformKeyTimes [ OK ] WebTransformAnimationCurveTest.RepeatedTransformKeyTimes (0 ms) [ RUN ] WebTransformAnimationCurveTest.UnsortedKeyframes [ OK ] WebTransformAnimationCurveTest.UnsortedKeyframes (0 ms) [ RUN ] WebTransformAnimationCurveTest.CubicBezierTimingFunction [ OK ] WebTransformAnimationCurveTest.CubicBezierTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.EaseTimingFunction [ OK ] WebTransformAnimationCurveTest.EaseTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.LinearTimingFunction [ OK ] WebTransformAnimationCurveTest.LinearTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.EaseInTimingFunction [ OK ] WebTransformAnimationCurveTest.EaseInTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.EaseOutTimingFunction [ OK ] WebTransformAnimationCurveTest.EaseOutTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.EaseInOutTimingFunction [ OK ] WebTransformAnimationCurveTest.EaseInOutTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.CustomBezierTimingFunction [ OK ] WebTransformAnimationCurveTest.CustomBezierTimingFunction (0 ms) [ RUN ] WebTransformAnimationCurveTest.DefaultTimingFunction [ OK ] WebTransformAnimationCurveTest.DefaultTimingFunction (0 ms) [----------] 13 tests from WebTransformAnimationCurveTest (0 ms total) [----------] 5 tests from WebSocketExtensionDispatcherTest [ RUN ] WebSocketExtensionDispatcherTest.TestSingle [ OK ] WebSocketExtensionDispatcherTest.TestSingle (0 ms) [ RUN ] WebSocketExtensionDispatcherTest.TestParameters [ OK ] WebSocketExtensionDispatcherTest.TestParameters (0 ms) [ RUN ] WebSocketExtensionDispatcherTest.TestMultiple [ OK ] WebSocketExtensionDispatcherTest.TestMultiple (0 ms) [ RUN ] WebSocketExtensionDispatcherTest.TestQuotedString [ OK ] WebSocketExtensionDispatcherTest.TestQuotedString (0 ms) [ RUN ] WebSocketExtensionDispatcherTest.TestInvalid [ OK ] WebSocketExtensionDispatcherTest.TestInvalid (0 ms) [----------] 5 tests from WebSocketExtensionDispatcherTest (0 ms total) [----------] 5 tests from WebSocketDeflaterTest [ RUN ] WebSocketDeflaterTest.TestCompressHello [ OK ] WebSocketDeflaterTest.TestCompressHello (0 ms) [ RUN ] WebSocketDeflaterTest.TestMultipleAddBytesCalls [ OK ] WebSocketDeflaterTest.TestMultipleAddBytesCalls (0 ms) [ RUN ] WebSocketDeflaterTest.TestNoContextTakeOver [ OK ] WebSocketDeflaterTest.TestNoContextTakeOver (0 ms) [ RUN ] WebSocketDeflaterTest.TestWindowBits [ OK ] WebSocketDeflaterTest.TestWindowBits (0 ms) [ RUN ] WebSocketDeflaterTest.TestLargeData [ OK ] WebSocketDeflaterTest.TestLargeData (366 ms) [----------] 5 tests from WebSocketDeflaterTest (366 ms total) [----------] 2 tests from WebPageSerializerTest [ RUN ] WebPageSerializerTest.HTMLNodes [25999:26007:0701/200738:756734875:WARNING:proxy_service.cc(966)] PAC support disabled because there is no system implementation [25999:25999:0701/200738:756738034:WARNING:test_suite.cc(97)] AtExitManager: items were added to the callback list by WebPageSerializerTest.HTMLNodes. Global state should be cleaned up before a test exits. [ OK ] WebPageSerializerTest.HTMLNodes (8 ms) [ RUN ] WebPageSerializerTest.MultipleFrames [ OK ] WebPageSerializerTest.MultipleFrames (19 ms) [----------] 2 tests from WebPageSerializerTest (27 ms total) [----------] 5 tests from WebPageNewSerializeTest [ RUN ] WebPageNewSerializeTest.PageWithFrames [ OK ] WebPageNewSerializeTest.PageWithFrames (9 ms) [ RUN ] WebPageNewSerializeTest.FAILS_CSSResources [ OK ] WebPageNewSerializeTest.FAILS_CSSResources (17 ms) [ RUN ] WebPageNewSerializeTest.BlankFrames [ OK ] WebPageNewSerializeTest.BlankFrames (30 ms) [ RUN ] WebPageNewSerializeTest.SerializeXMLHasRightDeclaration [ OK ] WebPageNewSerializeTest.SerializeXMLHasRightDeclaration (1 ms) [ RUN ] WebPageNewSerializeTest.FAILS_TestMHTMLEncoding [ OK ] WebPageNewSerializeTest.FAILS_TestMHTMLEncoding (10 ms) [----------] 5 tests from WebPageNewSerializeTest (67 ms total) [----------] 4 tests from WebMediaPlayerClientImplTest [ RUN ] WebMediaPlayerClientImplTest.InitialNullVideoClient [ OK ] WebMediaPlayerClientImplTest.InitialNullVideoClient (0 ms) [ RUN ] WebMediaPlayerClientImplTest.SetAndUnsetVideoClient [ OK ] WebMediaPlayerClientImplTest.SetAndUnsetVideoClient (0 ms) [ RUN ] WebMediaPlayerClientImplTest.DestroyProvider [ OK ] WebMediaPlayerClientImplTest.DestroyProvider (0 ms) [ RUN ] WebMediaPlayerClientImplTest.SetMultipleVideoClients [ OK ] WebMediaPlayerClientImplTest.SetMultipleVideoClients (0 ms) [----------] 4 tests from WebMediaPlayerClientImplTest (0 ms total) [----------] 1 test from WebLayerTreeViewSingleThreadTest [ RUN ] WebLayerTreeViewSingleThreadTest.InstrumentationCallbacks [ OK ] WebLayerTreeViewSingleThreadTest.InstrumentationCallbacks (0 ms) [----------] 1 test from WebLayerTreeViewSingleThreadTest (0 ms total) [----------] 1 test from WebLayerTreeViewThreadedTest [ RUN ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks [ OK ] WebLayerTreeViewThreadedTest.InstrumentationCallbacks (1 ms) [----------] 1 test from WebLayerTreeViewThreadedTest (1 ms total) [----------] 2 tests from WebLayerTest [ RUN ] WebLayerTest.Client [ OK ] WebLayerTest.Client (1 ms) [ RUN ] WebLayerTest.Hierarchy [ OK ] WebLayerTest.Hierarchy (0 ms) [----------] 2 tests from WebLayerTest (1 ms total) [----------] 20 tests from WebFrameTest [ RUN ] WebFrameTest.ContentText [ OK ] WebFrameTest.ContentText (4 ms) [ RUN ] WebFrameTest.FrameForEnteredContext [ OK ] WebFrameTest.FrameForEnteredContext (9 ms) [ RUN ] WebFrameTest.FormWithNullFrame [ OK ] WebFrameTest.FormWithNullFrame (1 ms) [ RUN ] WebFrameTest.ChromePageJavascript [ OK ] WebFrameTest.ChromePageJavascript (5 ms) [ RUN ] WebFrameTest.ChromePageNoJavascript [ OK ] WebFrameTest.ChromePageNoJavascript (1 ms) [ RUN ] WebFrameTest.DispatchMessageEventWithOriginCheck [ OK ] WebFrameTest.DispatchMessageEventWithOriginCheck (5 ms) [ RUN ] WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag [ OK ] WebFrameTest.DeviceScaleFactorUsesDefaultWithoutViewportTag (2 ms) [ RUN ] WebFrameTest.FixedLayoutInitializeAtMinimumPageScale [ OK ] WebFrameTest.FixedLayoutInitializeAtMinimumPageScale (1 ms) [ RUN ] WebFrameTest.CanOverrideMaximumScaleFactor [ OK ] WebFrameTest.CanOverrideMaximumScaleFactor (2 ms) [ RUN ] WebFrameTest.DivAutoZoomParamsTest [ OK ] WebFrameTest.DivAutoZoomParamsTest (3 ms) [ RUN ] WebFrameTest.ReloadDoesntSetRedirect [ OK ] WebFrameTest.ReloadDoesntSetRedirect (2 ms) [ RUN ] WebFrameTest.ReloadWithOverrideURLPreservesState [ OK ] WebFrameTest.ReloadWithOverrideURLPreservesState (6 ms) [ RUN ] WebFrameTest.IframeRedirect [ OK ] WebFrameTest.IframeRedirect (12 ms) [ RUN ] WebFrameTest.ClearFocusedNodeTest [ OK ] WebFrameTest.ClearFocusedNodeTest (10 ms) [ RUN ] WebFrameTest.ContextNotificationsLoadUnload [ OK ] WebFrameTest.ContextNotificationsLoadUnload (8 ms) [ RUN ] WebFrameTest.ContextNotificationsReload [ OK ] WebFrameTest.ContextNotificationsReload (15 ms) [ RUN ] WebFrameTest.ContextNotificationsIsolatedWorlds [ OK ] WebFrameTest.ContextNotificationsIsolatedWorlds (26 ms) [ RUN ] WebFrameTest.FindInPage [ OK ] WebFrameTest.FindInPage (5 ms) [ RUN ] WebFrameTest.GetContentAsPlainText [ OK ] WebFrameTest.GetContentAsPlainText (3 ms) [ RUN ] WebFrameTest.GetFullHtmlOfPage [ OK ] WebFrameTest.GetFullHtmlOfPage (2 ms) [----------] 20 tests from WebFrameTest (122 ms total) [----------] 13 tests from WebFloatAnimationCurveTest [ RUN ] WebFloatAnimationCurveTest.OneFloatKeyframe [ OK ] WebFloatAnimationCurveTest.OneFloatKeyframe (0 ms) [ RUN ] WebFloatAnimationCurveTest.TwoFloatKeyframe [ OK ] WebFloatAnimationCurveTest.TwoFloatKeyframe (0 ms) [ RUN ] WebFloatAnimationCurveTest.ThreeFloatKeyframe [ OK ] WebFloatAnimationCurveTest.ThreeFloatKeyframe (0 ms) [ RUN ] WebFloatAnimationCurveTest.RepeatedFloatKeyTimes [ OK ] WebFloatAnimationCurveTest.RepeatedFloatKeyTimes (0 ms) [ RUN ] WebFloatAnimationCurveTest.UnsortedKeyframes [ OK ] WebFloatAnimationCurveTest.UnsortedKeyframes (0 ms) [ RUN ] WebFloatAnimationCurveTest.CubicBezierTimingFunction [ OK ] WebFloatAnimationCurveTest.CubicBezierTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.EaseTimingFunction [ OK ] WebFloatAnimationCurveTest.EaseTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.LinearTimingFunction [ OK ] WebFloatAnimationCurveTest.LinearTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.EaseInTimingFunction [ OK ] WebFloatAnimationCurveTest.EaseInTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.EaseOutTimingFunction [ OK ] WebFloatAnimationCurveTest.EaseOutTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.EaseInOutTimingFunction [ OK ] WebFloatAnimationCurveTest.EaseInOutTimingFunction (1 ms) [ RUN ] WebFloatAnimationCurveTest.CustomBezierTimingFunction [ OK ] WebFloatAnimationCurveTest.CustomBezierTimingFunction (0 ms) [ RUN ] WebFloatAnimationCurveTest.DefaultTimingFunction [ OK ] WebFloatAnimationCurveTest.DefaultTimingFunction (0 ms) [----------] 13 tests from WebFloatAnimationCurveTest (1 ms total) [----------] 1 test from WebCompositorInputHandlerImpl [ RUN ] WebCompositorInputHandlerImpl.fromIdentifier [ OK ] WebCompositorInputHandlerImpl.fromIdentifier (0 ms) [----------] 1 test from WebCompositorInputHandlerImpl (0 ms total) [----------] 9 tests from WebCompositorInputHandlerImplTest [ RUN ] WebCompositorInputHandlerImplTest.gestureScrollStarted [ OK ] WebCompositorInputHandlerImplTest.gestureScrollStarted (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureScrollOnMainThread [ OK ] WebCompositorInputHandlerImplTest.gestureScrollOnMainThread (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureScrollIgnored [ OK ] WebCompositorInputHandlerImplTest.gestureScrollIgnored (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gesturePinch [ OK ] WebCompositorInputHandlerImplTest.gesturePinch (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureFlingStarted [ OK ] WebCompositorInputHandlerImplTest.gestureFlingStarted (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureFlingFailed [ OK ] WebCompositorInputHandlerImplTest.gestureFlingFailed (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureFlingIgnored [ OK ] WebCompositorInputHandlerImplTest.gestureFlingIgnored (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureFlingAnimates [ OK ] WebCompositorInputHandlerImplTest.gestureFlingAnimates (0 ms) [ RUN ] WebCompositorInputHandlerImplTest.gestureFlingTransferResets [ OK ] WebCompositorInputHandlerImplTest.gestureFlingTransferResets (0 ms) [----------] 9 tests from WebCompositorInputHandlerImplTest (1 ms total) [----------] 2 tests from WebAnimationTest [ RUN ] WebAnimationTest.DefaultSettings base::debug::StackTrace::StackTrace() [0x88aabc2] base::(anonymous namespace)::StackDumpSignalHandler() [0x88a249d] 0xb7774400 (anonymous namespace)::WebAnimationTest_DefaultSettings_Test::TestBody() [0x86bea52] testing::internal::HandleExceptionsInMethodIfSupported<>() [0x8886ee2] testing::Test::Run() [0x8887d81] testing::TestInfo::Run() [0x8887e32] testing::TestCase::Run() [0x8887f74] testing::internal::UnitTestImpl::RunAllTests() [0x888828e] testing::UnitTest::Run() [0x8886e6e] base::TestSuite::Run() [0x88b23fb] main [0x805c073] 0xb6a71bd6 0x805bf51 Stopping Xvfb with pid 25996 ... Xvfb pid file removed 4 new files were left in /tmp: Fix the tests to clean up themselves. program finished with exit code 1 elapsedTime=1.128414 Created attachment 150840 [details]
Patch for landing
Comment on attachment 150840 [details] Patch for landing Clearing flags on attachment: 150840 Committed r121922: <http://trac.webkit.org/changeset/121922> All reviewed patches have been landed. Closing bug. |