Bug 90283

Summary:

[Qt] Add gprof.prf to build WebKit with gprof enabled

Product:

WebKit

Reporter:

Kwang Yul Seo <skyul>

Component:

WebKit Qt

Assignee:

Kwang Yul Seo <skyul>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dongseong.hwang, eric, hausmann, kevino, koivisto, morrita, ossy, vestbo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Kwang Yul Seo

Reported 2012-06-29 08:11:10 PDT

Build WebKit with gprof enabled by passing --qmakearg="CONFIG+=gprof" option to build-webkit script.

Attachments
Patch (6.79 KB, patch) 2012-06-29 08:29 PDT, Kwang Yul Seo	no flags	Details Formatted Diff Diff
Patch for landing (5.80 KB, patch) 2012-08-13 04:51 PDT, Kwang Yul Seo	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Kwang Yul Seo

Comment 1 2012-06-29 08:29:55 PDT

Created attachment 150187 [details] Patch

Eric Seidel (no email)

Comment 2 2012-08-12 03:50:18 PDT

Comment on attachment 150187 [details] Patch rs=me.

WebKit Review Bot

Comment 3 2012-08-12 03:51:58 PDT

Comment on attachment 150187 [details] Patch Rejecting attachment 150187 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: mpRenderTree.pro Hunk #1 FAILED at 37. Hunk #2 succeeded at 48 (offset -1 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/qt/DumpRenderTree.pro.rej patching file Tools/qmake/mkspecs/features/functions.prf Hunk #1 succeeded at 260 (offset -20 lines). patching file Tools/qmake/mkspecs/features/gprof.prf Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13483425

Kwang Yul Seo

Comment 4 2012-08-12 21:51:14 PDT

(In reply to comment #3) > (From update of attachment 150187 [details]) > Rejecting attachment 150187 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > mpRenderTree.pro > Hunk #1 FAILED at 37. > Hunk #2 succeeded at 48 (offset -1 lines). > 1 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/qt/DumpRenderTree.pro.rej > patching file Tools/qmake/mkspecs/features/functions.prf > Hunk #1 succeeded at 260 (offset -20 lines). > patching file Tools/qmake/mkspecs/features/gprof.prf > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/13483425 This patch is ancient. I will land the patch after rebasing it to the latest revision.

Kwang Yul Seo

Comment 5 2012-08-13 04:51:46 PDT

Created attachment 157961 [details] Patch for landing

WebKit Review Bot

Comment 6 2012-08-13 05:07:52 PDT

Comment on attachment 157961 [details] Patch for landing Clearing flags on attachment: 157961 Committed r125411: <http://trac.webkit.org/changeset/125411>

WebKit Review Bot

Comment 7 2012-08-13 05:07:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.