Bug 90274

Summary: Optimize Element::getAttributeNode() by replacing String with AtomicString
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: DOMAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cmarcelo, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90246    
Attachments:
Description Flags
Performance test
none
Patch none

Kentaro Hara
Reported 2012-06-29 05:16:19 PDT
Based on the observation described in this ChangeLog (http://trac.webkit.org/changeset/121439), the performance of Element::getAttributeNode() can be optimized by replacing String with AtomicString.
Attachments
Performance test (1.56 KB, text/html)
2012-06-29 05:20 PDT, Kentaro Hara 		no flags
Details
Patch (3.25 KB, patch)
2012-06-29 05:24 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-06-29 05:20:24 PDT
Created attachment 150147 [details] Performance test
Kentaro Hara
Comment 2 2012-06-29 05:24:15 PDT
Created attachment 150148 [details] Patch
Adam Barth
Comment 3 2012-07-27 01:05:04 PDT
Comment on attachment 150148 [details] Patch Based on further discussion in #webkit, my current understanding is that ap is ok with these patches. I'm going to r+ them, but please give ap a chance to respond before landing.
Darin Adler
Comment 4 2012-07-27 07:08:36 PDT
Comment on attachment 150148 [details] Patch This is faster in some cases. But a case I’d expect this makes slower is when the passed-in attribute name is uppercase. This adds a lookup in the atomic string table of the not-yet-lowercased string.
Kentaro Hara
Comment 5 2012-08-07 18:21:59 PDT
Comment on attachment 150148 [details] Patch Looks like no strong objection, let me commit it.
WebKit Review Bot
Comment 6 2012-08-07 19:41:36 PDT
Comment on attachment 150148 [details] Patch Clearing flags on attachment: 150148 Committed r124972: <http://trac.webkit.org/changeset/124972>
WebKit Review Bot
Comment 7 2012-08-07 19:41:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.