Textarea unnecessarily saves the value in some cases

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

HTMLTextAreaElement::saveFormControlState() has a code like:

    if (currentValue == defaultValue())
        return FormControlState();

It's wrong because
 - We don't apply EOL normalization to defaultValue(), though does it to currentValue.
 - currentValue can be a null string.

[Kent Tamura]

Rename the title because webkit-patch can't handle <textarea> in the title.

[Kent Tamura]

Created attachment 150117 [details]
Patch

[Hajime Morrita]

Comment on attachment 150117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150117&action=review

Code is OK. added some nits.

> LayoutTests/fast/forms/textarea/textarea-state-restore.html:16
> +    document.write('<div id=parent><form id=form1 action="data:text/html,&lt;script>history.back()&lt;/script>">');

Could the test data more readable?
It's hard to see compare HTML between two stages.
I think it's better to have small duplication to improve readability.

[Kent Tamura]

Created attachment 150119 [details]
Patch for landing

Improve readability of the test code

[WebKit Review Bot]

Comment on attachment 150119 [details]
Patch for landing

Clearing flags on attachment: 150119

Committed r121552: <http://trac.webkit.org/changeset/121552>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.