Bug 90188

Summary: Web Inspector: Add toggle breakpoint shortcut.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dubroy, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Vsevolod Vlasov
Reported 2012-06-28 10:38:46 PDT
Patch to follow.
Attachments
Patch (6.46 KB, patch)
2012-06-28 10:40 PDT, Vsevolod Vlasov 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-28 10:40:54 PDT
Created attachment 149970 [details] Patch
Vsevolod Vlasov
Comment 2 2012-06-29 02:12:28 PDT
Committed r121535: <http://trac.webkit.org/changeset/121535>
dubroy
Comment 3 2012-06-30 02:23:00 PDT
We should probably add F9 as a toggle breakpoint shortcut, since F10 and F11 already use the VS mappings, and it's helpful for those keys to be beside each other. As for Ctrl-B, does that match an existing editor? It seems like VS is F9 and Eclipse is Ctrl+Shift-B. Ctrl-B in VS opens the new breakpoint dialog, which is similar, but not quite the same. We might support a similar dialog (e.g. for creating a new conditional breakpoint), so I'd be inclined to go with Ctrl+Shift-B as the shortcut for toggle breakpoint (in addition to F9).
Note You need to log in before you can comment on or make changes to this bug.