Bug 90178

Summary: [Qt] Remove unnecessary AffineTransform construction while calling Pattern::createPlatformPattern
Product: WebKit Reporter: Bruno Abinader (history only) <bruno.abinader>
Component: WebKit QtAssignee: Bruno Abinader (history only) <bruno.abinader>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, igor.oliveira, kenneth, noam, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Bruno Abinader (history only)
Reported 2012-06-28 07:13:09 PDT
Qt currently ignores the const AffineTransform& parameter on Pattern::createPlatformPattern, so removing it from all its Qt calls and changing the function signature if platform is Qt would be a good fix.
Attachments
Proposed patch (7.64 KB, patch)
2012-06-28 07:16 PDT, Bruno Abinader (history only) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bruno Abinader (history only)
Comment 1 2012-06-28 07:16:59 PDT
Created attachment 149949 [details] Proposed patch This patch fixes the issue by removing all unused calls for AffineTransform. I also thought about adding a clear AffineTransform object as default parameter for the Pattern::createPlatformPattern function, but it would still be creating an unused object on Qt afterall. What do you guys think?
WebKit Review Bot
Comment 2 2012-06-28 18:45:53 PDT
Comment on attachment 149949 [details] Proposed patch Clearing flags on attachment: 149949 Committed r121503: <http://trac.webkit.org/changeset/121503>
WebKit Review Bot
Comment 3 2012-06-28 18:46:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.