Bug 90175

Summary: [BlackBerry] Implement GCActivityCallback with platform timer
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch
rwlbuis: review+
90175
none
again
none
the patch none

Yong Li
Reported 2012-06-28 06:55:41 PDT
Implement GCActivityCallback for PLATFORM(BLACKBERRY)
Attachments
the patch (4.21 KB, patch)
2012-07-13 10:11 PDT, Yong Li 		rwlbuis: review+
DetailsFormatted DiffDiff
90175 (4.07 KB, patch)
2012-07-13 10:28 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
again (4.03 KB, patch)
2012-07-13 11:19 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
the patch (1.25 KB, patch)
2012-07-23 08:07 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-07-13 10:11:35 PDT
Created attachment 152285 [details] the patch
Rob Buis
Comment 2 2012-07-13 10:23:16 PDT
Comment on attachment 152285 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=152285&action=review LGTM. > Source/JavaScriptCore/heap/HeapTimer.h:70 > + bool m_valid; May be a bit strange to declare before the getter.
Yong Li
Comment 3 2012-07-13 10:28:41 PDT
Created attachment 152292 [details] 90175
Yong Li
Comment 4 2012-07-13 11:19:23 PDT
Created attachment 152307 [details] again
WebKit Review Bot
Comment 5 2012-07-13 13:12:49 PDT
Comment on attachment 152307 [details] again Clearing flags on attachment: 152307 Committed r122624: <http://trac.webkit.org/changeset/122624>
WebKit Review Bot
Comment 6 2012-07-13 13:12:53 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 7 2012-07-23 07:43:37 PDT
Reopen to use a JSLock when doing GC to avoid assertions
Yong Li
Comment 8 2012-07-23 08:07:43 PDT
Created attachment 153799 [details] the patch
Rob Buis
Comment 9 2012-07-23 08:10:58 PDT
Comment on attachment 153799 [details] the patch Looks good.
WebKit Review Bot
Comment 10 2012-07-23 08:49:50 PDT
Comment on attachment 153799 [details] the patch Clearing flags on attachment: 153799 Committed r123342: <http://trac.webkit.org/changeset/123342>
WebKit Review Bot
Comment 11 2012-07-23 08:49:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.