Summary: | Optimize Dromaeo/dom-attr.html by speeding up Element::getAttribute() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | DOM | Assignee: | Kentaro Hara <haraken> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, darin, rniwa, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kentaro Hara
2012-06-28 06:48:52 PDT
Created attachment 149944 [details]
Patch
Created attachment 149945 [details]
Patch
Comment on attachment 149945 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149945&action=review > Source/WebCore/dom/Element.h:146 > const AtomicString& getAttributeNS(const String& namespaceURI, const String& localName) const; Should we do the same for getAttributeNS? (In reply to comment #3) > > Source/WebCore/dom/Element.h:146 > > const AtomicString& getAttributeNS(const String& namespaceURI, const String& localName) const; > > Should we do the same for getAttributeNS? Let me do it in a follow-up patch. getAttributeNode() would be another place. Comment on attachment 149945 [details] Patch Clearing flags on attachment: 149945 Committed r121439: <http://trac.webkit.org/changeset/121439> All reviewed patches have been landed. Closing bug. |