Bug 90159 – user-select: none cursor turns to I-beam on mouse dragging

• Component: UI Events
• Status: RESOLVED INVALID

[Yves Van Goethem]

Observation:
When you start selecting an area that has user-select:none; and drag the cursor around, it changes to a text cursor.

Expected:
The cursor should be default as defined.

[Vani Hegde]

Created attachment 212536 [details]
Patch

[Vani Hegde]

This has got nothing to do with user-select:none. The bug here is cursor type being changed to text cursor(I-Beam cursor) during selection, even when the cursor type is explicitly set to be something else.

This is committed in blink https://codereview.chromium.org/23461040/

[Ryosuke Niwa]

It seems like this is done intentionally. I'm not sure changing this behavior is desirable.

[Ryosuke Niwa]

Hm... looking more closely, maybe this is a regression from http://trac.webkit.org/changeset/11490.

[Ryosuke Niwa]

Comment on attachment 212536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review

> Source/WebCore/page/EventHandler.cpp:1371
> +        // During selection, use an I-beam no matter what we're over.

We should probably rephrase this comment to something along the line of "use an I-beam regardless of the content beneath the cursor when cursor is not explicitly specified."
since now we're respecting cursor CSS property during text selection.

[Ryosuke Niwa]

Comment on attachment 212536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review

> LayoutTests/editing/caret/selection-with-caret-type-progress.html:10
> +    description('Tests whether explicitly set caret style is retained on performing text selection');

The description can be outside of this if.
It would be nice if you had something like debug("This test requires eventSender") in the else clause. Better yet, explain how to manually test it.

[Radar WebKit Bug Importer]

<rdar://problem/15078860>

[Vani Hegde]

(In reply to comment #5)
> (From update of attachment 212536 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212536&action=review
> 
> > Source/WebCore/page/EventHandler.cpp:1371
> > +        // During selection, use an I-beam no matter what we're over.
> 
> We should probably rephrase this comment to something along the line of "use an I-beam regardless of the content beneath the cursor when cursor is not explicitly specified."
> since now we're respecting cursor CSS property during text selection.

Will do.

[Vani Hegde]

Created attachment 212658 [details]
Patch

[Vani Hegde]

Uploaded patch with review comments incorporated.

[WebKit Commit Bot]

Comment on attachment 212658 [details]
Patch

Clearing flags on attachment: 212658

Committed r156635: <http://trac.webkit.org/changeset/156635>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

(In reply to comment #11)
> (From update of attachment 212658 [details])
> Clearing flags on attachment: 212658
> 
> Committed r156635: <http://trac.webkit.org/changeset/156635>

This caused bug 127197.

[Ryosuke Niwa]

(In reply to comment #13)
> (In reply to comment #11)
> > (From update of attachment 212658 [details] [details])
> > Clearing flags on attachment: 212658
> > 
> > Committed r156635: <http://trac.webkit.org/changeset/156635>
> 
> This caused bug 127197.

As I suspect, the old behavior was indeed intended.  Revering the patch.

[Ryosuke Niwa]

Reverted the patch in http://trac.webkit.org/changeset/167688.