Bug 90155

Summary: [Qt] Restore original value of mock scrollbars between tests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: marcelo.lira, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2012-06-28 03:56:15 PDT
https://bugs.webkit.org/show_bug.cgi?id=87680 - Restore original value of mock scrollbars enabled in InternalSettings ^^^^^^ It is the general way to solve resetting mock scrollbars for all port, but it seems it kills chromium. :) What if we try to reset mock scrollbars for Qt port only similar to EFL port: http://trac.webkit.org/changeset/97464
Attachments
Patch (7.36 KB, patch)
2012-06-28 04:03 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
Patch (14.44 KB, patch)
2012-09-10 11:36 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-06-28 04:03:01 PDT
Created attachment 149918 [details] Patch
Simon Hausmann
Comment 2 2012-06-28 04:08:56 PDT
Comment on attachment 149918 [details] Patch Okay, but maybe add a comment in bug #87680 to roll out this change again when it's done internally.
Csaba Osztrogonác
Comment 3 2012-06-28 04:12:28 PDT
(In reply to comment #2) > (From update of attachment 149918 [details]) > Okay, but maybe add a comment in bug #87680 to roll out this change again when it's done internally. Sure. I was writing that comment when you r+-ed the patch. :)
Csaba Osztrogonác
Comment 4 2012-06-28 04:39:43 PDT
Comment on attachment 149918 [details] Patch Clearing flags on attachment: 149918 Committed r121425: <http://trac.webkit.org/changeset/121425>
Csaba Osztrogonác
Comment 5 2012-06-28 04:39:51 PDT
All reviewed patches have been landed. Closing bug.
Marcelo Lira
Comment 6 2012-09-10 11:36:24 PDT
Reopening to attach new patch.
Marcelo Lira
Comment 7 2012-09-10 11:36:27 PDT
Created attachment 163171 [details] Patch
Marcelo Lira
Comment 8 2012-09-10 11:37:59 PDT
This patch was mistakenly uploaded here. Sorry, closing bug again.
Simon Hausmann
Comment 9 2012-09-13 22:31:12 PDT
Comment on attachment 163171 [details] Patch Clearing review, as the patch was mistakenly attached it seems.
Note You need to log in before you can comment on or make changes to this bug.