Bug 90155

Summary: [Qt] Restore original value of mock scrollbars between tests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: marcelo.lira, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Csaba Osztrogonác 2012-06-28 03:56:15 PDT 
https://bugs.webkit.org/show_bug.cgi?id=87680 - Restore original value of mock scrollbars enabled in InternalSettings
^^^^^^
It is the general way to solve resetting mock scrollbars for all port, but it seems it kills chromium. :)

What if we try to reset mock scrollbars for Qt port only similar to EFL port:
http://trac.webkit.org/changeset/97464
Comment 1 Csaba Osztrogonác 2012-06-28 04:03:01 PDT 
Created attachment 149918 [details]
Patch
Comment 2 Simon Hausmann 2012-06-28 04:08:56 PDT 
Comment on attachment 149918 [details]
Patch

Okay, but maybe add a comment in bug #87680 to roll out this change again when it's done internally.
Comment 3 Csaba Osztrogonác 2012-06-28 04:12:28 PDT 
(In reply to comment #2)
> (From update of attachment 149918 [details])
> Okay, but maybe add a comment in bug #87680 to roll out this change again when it's done internally.

Sure. I was writing that comment when you r+-ed the patch. :)
Comment 4 Csaba Osztrogonác 2012-06-28 04:39:43 PDT 
Comment on attachment 149918 [details]
Patch

Clearing flags on attachment: 149918

Committed r121425: <http://trac.webkit.org/changeset/121425>
Comment 5 Csaba Osztrogonác 2012-06-28 04:39:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Marcelo Lira 2012-09-10 11:36:24 PDT 
Reopening to attach new patch.
Comment 7 Marcelo Lira 2012-09-10 11:36:27 PDT 
Created attachment 163171 [details]
Patch
Comment 8 Marcelo Lira 2012-09-10 11:37:59 PDT 
This patch was mistakenly uploaded here.
Sorry, closing bug again.
Comment 9 Simon Hausmann 2012-09-13 22:31:12 PDT 
Comment on attachment 163171 [details]
Patch

Clearing review, as the patch was mistakenly attached it seems.