Web Inspector: [Regression] Resource content is not loaded if Resource.requestContent method is called before network request is finished.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Vsevolod Vlasov]

Steps to reproduce:
1) Open webkit.org
2) open main.css in Sources Panel
3) reload several times, try pressing ctrl+r several times very often

Sometimes (quite often) main.css is shown in sources panel without any content.

This is happening since Resource-NetworkRequest split because Resource.requestContent does not check that associated request was already loaded.

Patch to follow.

[Vsevolod Vlasov]

Created attachment 149932 [details]
Patch

[Yury Semikhatsky]

Comment on attachment 149932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149932&action=review

> LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-loading.html:27
> +          contentWasRequested = true;

No need to set it second time

> LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-loading.html:38
> +          if (contentWasLoaded)

Page reload reply should always come before _addRequest unless you receive _addRequest for the page that was not reloaded yet. Probably using a synchronously loaded resources would allow to avoid this non-determinism.

[Vsevolod Vlasov]

Regression introduced in r114116

[Vsevolod Vlasov]

Committed r121537: <http://trac.webkit.org/changeset/121537>

[Vsevolod Vlasov]

(In reply to comment #2)
> (From update of attachment 149932 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=149932&action=review
> 
> > LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-loading.html:27
> > +          contentWasRequested = true;
> 
> No need to set it second time
Done.

> > LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-loading.html:38
> > +          if (contentWasLoaded)
> 
> Page reload reply should always come before _addRequest unless you receive _addRequest for the page that was not reloaded yet. Probably using a synchronously loaded resources would allow to avoid this non-determinism.
It turned out I didn't need all this page reloaded events, landed without listening to them.