Summary: | Web Inspector: add v8 bindings memory info to the native memory graph | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, alph, apavlov, bweinstein, gustavo, haraken, japhet, jochen, joepeck, keishi, loislo, pfeldman, philn, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 87262, 90358 | ||||||||
Attachments: |
|
Description
Yury Semikhatsky
2012-06-28 02:23:10 PDT
Created attachment 149907 [details]
Patch
Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13102964 Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13107110 Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13111045 Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13107111 Created attachment 149914 [details]
Patch
Comment on attachment 149914 [details] Patch Attachment 149914 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13118130 Comment on attachment 149914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149914&action=review > Source/WebCore/bindings/js/ScriptProfiler.h:81 > + static void collectBindingMemoryInfo(MemoryInstrumentation*) { } Please file a bug requesting that it is implemented for JSC and put FIXME here. > Source/WebCore/bindings/v8/V8Binding.cpp:95 > + instrumentation->reportPointer(this, MemoryInstrumentation::Binding); I wonder if we could have a macro for these... Comment on attachment 149914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149914&action=review >> Source/WebCore/bindings/js/ScriptProfiler.h:81 >> + static void collectBindingMemoryInfo(MemoryInstrumentation*) { } > > Please file a bug requesting that it is implemented for JSC and put FIXME here. Done. Committed r121658: <http://trac.webkit.org/changeset/121658> |