Bug 90149

Summary: Web Inspector: add v8 bindings memory info to the native memory graph
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, alph, apavlov, bweinstein, gustavo, haraken, japhet, jochen, joepeck, keishi, loislo, pfeldman, philn, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 87262, 90358    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+, gyuyoung.kim: commit-queue-

Yury Semikhatsky
Reported 2012-06-28 02:23:10 PDT
There are several maps in the binding layer that grow when number of nodes increases. They should be presented on the memory chart.
Attachments
Patch (14.42 KB, patch)
2012-06-28 02:38 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (14.61 KB, patch)
2012-06-28 03:30 PDT, Yury Semikhatsky 		pfeldman: review+
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-06-28 02:38:36 PDT
Created attachment 149907 [details] Patch
Early Warning System Bot
Comment 2 2012-06-28 02:58:23 PDT
Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13102964
Early Warning System Bot
Comment 3 2012-06-28 03:03:33 PDT
Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13107110
Build Bot
Comment 4 2012-06-28 03:07:05 PDT
Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13111045
Gyuyoung Kim
Comment 5 2012-06-28 03:08:36 PDT
Comment on attachment 149907 [details] Patch Attachment 149907 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13107111
Yury Semikhatsky
Comment 6 2012-06-28 03:30:26 PDT
Created attachment 149914 [details] Patch
Gyuyoung Kim
Comment 7 2012-06-28 18:19:43 PDT
Comment on attachment 149914 [details] Patch Attachment 149914 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13118130
Pavel Feldman
Comment 8 2012-06-29 07:28:10 PDT
Comment on attachment 149914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149914&action=review > Source/WebCore/bindings/js/ScriptProfiler.h:81 > + static void collectBindingMemoryInfo(MemoryInstrumentation*) { } Please file a bug requesting that it is implemented for JSC and put FIXME here. > Source/WebCore/bindings/v8/V8Binding.cpp:95 > + instrumentation->reportPointer(this, MemoryInstrumentation::Binding); I wonder if we could have a macro for these...
Yury Semikhatsky
Comment 9 2012-07-02 00:03:04 PDT
Comment on attachment 149914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149914&action=review >> Source/WebCore/bindings/js/ScriptProfiler.h:81 >> + static void collectBindingMemoryInfo(MemoryInstrumentation*) { } > > Please file a bug requesting that it is implemented for JSC and put FIXME here. Done.
Yury Semikhatsky
Comment 10 2012-07-02 00:05:01 PDT
Committed r121658: <http://trac.webkit.org/changeset/121658>
Note You need to log in before you can comment on or make changes to this bug.