Bug 90146

Summary: DFG recompilation heuristics should be based on count, not rate
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, ggaren, mhahnenberg, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
work in progress
none
the patch oliver: review+

Description Filip Pizlo 2012-06-28 01:36:53 PDT
Patch forthcoming.

It should be noted that this bug is basically an experiment.  This patch will require a fair amount of testing before I'm convinced that it's a good idea to replace the current heuristics with these ones.
Comment 1 Filip Pizlo 2012-06-28 01:41:05 PDT
Created attachment 149901 [details]
work in progress

Just putting up for EWS.  Not ready for review yet.
Comment 2 Filip Pizlo 2012-06-28 15:51:40 PDT
Created attachment 150032 [details]
the patch
Comment 3 Filip Pizlo 2012-06-28 19:40:36 PDT
Landed in http://trac.webkit.org/changeset/121511
Comment 4 Filip Pizlo 2012-07-09 18:51:16 PDT
Rolled out in http://trac.webkit.org/changeset/122182
It made in-browser V8v7 10% slower.
Comment 5 Filip Pizlo 2012-07-10 02:20:22 PDT
Relanded in http://trac.webkit.org/changeset/122206