| Summary: | LayoutUnit::epsilon() is wrong | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Behdad Esfahbod <behdad> | ||||
| Component: | Platform | Assignee: | Behdad Esfahbod <behdad> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eae, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 149788 [details]
Patch
Looks good to me. While I'd like to see a test for this I realize it isn't really feasible to add one given that the method isn't actually used anywhere yet. Eric, could you use your magic reviewing powers on this one? Comment on attachment 149788 [details]
Patch
Happy to.
Comment on attachment 149788 [details] Patch Clearing flags on attachment: 149788 Committed r121709: <http://trac.webkit.org/changeset/121709> All reviewed patches have been landed. Closing bug. |
In platform/FractionalLayoutUnit.h: static float epsilon() { return 1 / kFixedPointDenominator; } That division is done as integers. So, if SUBPIXEL_LAYOUT is enabled, epsilon() always returns zero.