Summary: | REGRESSION(r121296): New zero-size background tests asserting on Mac. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, joethomas, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2012-06-27 06:45:14 PDT
With http://trac.webkit.org/changeset/121296, minimum size of the background-image is set to (0,0) as the spec mandates that. This makes the PatterTransform to be (0,0,0,0) and it hits the assertion. We also have a return statement after the assertion for the same condition. So I think we should remove this assertion as this is a valid case now. Please let me know your opinion on this. Thanks. Created attachment 149763 [details]
Patch
Comment on attachment 149763 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149763&action=review > Source/WebCore/platform/graphics/cg/ImageCG.cpp:233 > // Avoid a hang under CGContextDrawTiledImage on release builds. This comment needs to be changed or removed, since the return that follows is no longer specific to release builds. Created attachment 149765 [details]
Latch for panding
Comment on attachment 149765 [details] Latch for panding Clearing flags on attachment: 149765 Committed r121347: <http://trac.webkit.org/changeset/121347> All reviewed patches have been landed. Closing bug. |