[WK2] Add Vibration API support for WebKit2

• Component: WebKit2
• Status: RESOLVED FIXED

[Sudarsana Nagineni (babu)]

Currently there is no support for the Vibration API in WebKit2. We need to implement it.

[Sudarsana Nagineni (babu)]

Created attachment 149719 [details]
Patch

This patch covers adding support for the Vibration API to WebKit2.

[Gyuyoung Kim]

When I build this patch on latest WebKit, there is build break. Could you check this ?


/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h: In static member function ‘static void CoreIPC::ArgumentCoder<T>::encode(CoreIPC::ArgumentEncoder*, const T&) [with T = long unsigned int]’:
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:67:9:   instantiated from ‘void CoreIPC::ArgumentEncoder::encode(const T&) [with T = long unsigned int]’
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Arguments.h:72:9:   instantiated from ‘void CoreIPC::Arguments1<T1>::encode(CoreIPC::ArgumentEncoder*) const [with T1 = const long unsigned int&]’
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:39:9:   instantiated from ‘static void CoreIPC::ArgumentCoder<T>::encode(CoreIPC::ArgumentEncoder*, const T&) [with T = Messages::WebVibrationProxy::Vibrate]’
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.h:67:9:   instantiated from ‘void CoreIPC::ArgumentEncoder::encode(const T&) [with T = Messages::WebVibrationProxy::Vibrate]’
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/Connection.h:374:5:   instantiated from ‘bool CoreIPC::Connection::send(const T&, uint64_t, unsigned int) [with T = Messages::WebVibrationProxy::Vibrate, uint64_t = long long unsigned int]’
/home/gyuyoung/webkit/WebKit/Source/WebKit2/WebProcess/WebCoreSupport/WebVibrationClient.cpp:41:114:   instantiated from here
/home/gyuyoung/webkit/WebKit/Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:39:9: error: request for member ‘encode’ in ‘t’, which is of non-class type ‘const long unsigned int’
make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebCoreSupport/WebVibrationClient.cpp.o] Error 1

[Sudarsana Nagineni (babu)]

Created attachment 149943 [details]
Patch

Fixed 32-bit build issue.

[Gyuyoung Kim]

(In reply to comment #3)
> Created an attachment (id=149943) [details]
> Patch
> 
> Fixed 32-bit build issue.

Thanks, there is no build break now.

[Gyuyoung Kim]

Comment on attachment 149943 [details]
Patch

Though I'm not a WK2 reviewer, looks good to me.

[Chris Dumez]

Comment on attachment 149943 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 149943 [details]
Patch

Clearing flags on attachment: 149943

Committed r122270: <http://trac.webkit.org/changeset/122270>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.