Bug 89945

Summary:

Separate mutating CSSStyleDeclaration operations.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, dglazkov, gustavo, koivisto, macpherson, menard, philn, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch?	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none
Patch	koivisto: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-04	none
Patch v2	gyuyoung.kim: commit-queue-
Patch	webkit.review.bot: commit-queue-
Archive of layout-test-results from gce-cr-linux-01	none
Patch	koivisto: review+, webkit.review.bot: commit-queue-
Land already	none

Andreas Kling

Reported 2012-06-25 23:10:45 PDT

We should have a separate path for CSSStyleDeclaration operations that may cause the underlying property storage to mutate.

Attachments
Patch? (18.78 KB, patch) 2012-06-25 23:14 PDT, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-03 (657.29 KB, application/zip) 2012-06-26 01:24 PDT, WebKit Review Bot	no flags	Details
Patch (18.78 KB, patch) 2012-06-26 10:17 PDT, Andreas Kling	koivisto: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-04 (776.15 KB, application/zip) 2012-06-26 11:26 PDT, WebKit Review Bot	no flags	Details
Patch v2 (19.15 KB, patch) 2012-07-02 03:31 PDT, Andreas Kling	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
Patch (19.16 KB, patch) 2012-07-02 04:10 PDT, Andreas Kling	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-01 (573.52 KB, application/zip) 2012-07-02 06:13 PDT, WebKit Review Bot	no flags	Details
Patch (10.46 KB, patch) 2012-07-03 06:11 PDT, Andreas Kling	koivisto: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Land already (10.38 KB, patch) 2012-07-06 06:18 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2012-06-25 23:14:57 PDT

Created attachment 149461 [details] Patch?

WebKit Review Bot

Comment 2 2012-06-26 01:24:51 PDT

Comment on attachment 149461 [details] Patch? Attachment 149461 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13097369 New failing tests: platform/chromium/compositing/layout-width-change.html platform/chromium/compositing/render-surface-alpha-blending.html platform/chromium/compositing/tiny-layer-rotated.html platform/chromium/compositing/huge-layer-rotated.html fast/loader/loadInProgress.html platform/chromium/compositing/3d-corners.html platform/chromium/compositing/video-frame-size-change.html platform/chromium/compositing/perpendicular-layer-sorting.html fast/loader/unload-form-post-about-blank.html platform/chromium/compositing/child-layer-3d-sorting.html editing/pasteboard/paste-text-002.html platform/chromium/compositing/lost-compositor-context-permanently.html platform/chromium/compositing/lost-compositor-context-with-video.html platform/chromium/compositing/accelerated-drawing/alpha.html http/tests/xmlhttprequest/zero-length-response.html http/tests/security/script-crossorigin-loads-correctly.html platform/chromium/compositing/webgl-loses-compositor-context.html platform/chromium/compositing/backface-visibility-transformed.html platform/chromium/compositing/lost-compositor-context-with-rendersurface.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-008.html platform/chromium/compositing/lost-compositor-context.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-004.html platform/chromium/compositing/img-layer-grow.html platform/chromium/compositing/lost-compositor-context-twice.html

WebKit Review Bot

Comment 3 2012-06-26 01:24:55 PDT

Created attachment 149482 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Antti Koivisto

Comment 4 2012-06-26 05:08:59 PDT

Looks good modulo the test failures.

Andreas Kling

Comment 5 2012-06-26 10:17:35 PDT

Created attachment 149552 [details] Patch Let's give that another go (exactly the same patch) since I don't get any of these failures locally..

WebKit Review Bot

Comment 6 2012-06-26 11:26:09 PDT

Comment on attachment 149552 [details] Patch Attachment 149552 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13099466 New failing tests: editing/pasteboard/paste-text-002.html editing/pasteboard/paste-text-004.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-008.html

WebKit Review Bot

Comment 7 2012-06-26 11:26:13 PDT

Created attachment 149571 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Antti Koivisto

Comment 8 2012-06-26 12:14:02 PDT

Comment on attachment 149552 [details] Patch r=me

Andreas Kling

Comment 9 2012-06-29 08:21:00 PDT

(In reply to comment #6) > (From update of attachment 149552 [details]) > Attachment 149552 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13099466 > > New failing tests: > editing/pasteboard/paste-text-002.html > editing/pasteboard/paste-text-004.html > editing/pasteboard/paste-text-003.html > editing/pasteboard/paste-text-005.html > editing/pasteboard/paste-text-008.html Can't reproduce these failures, so I'm just gonna land-it-and-see-what-happens(tm).

Andreas Kling

Comment 10 2012-06-29 08:21:52 PDT

Committed r121562: <http://trac.webkit.org/changeset/121562>

Andreas Kling

Comment 11 2012-06-29 10:20:53 PDT

Reverted r121562 for reason: Broke Committed r121570: <http://trac.webkit.org/changeset/121570>

Andreas Kling

Comment 12 2012-07-02 03:31:18 PDT

Created attachment 150389 [details] Patch v2

Gyuyoung Kim

Comment 13 2012-07-02 03:40:50 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13133064

Early Warning System Bot

Comment 14 2012-07-02 03:45:14 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13125131

Early Warning System Bot

Comment 15 2012-07-02 03:49:48 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13127152

WebKit Review Bot

Comment 16 2012-07-02 03:50:18 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13126145

Build Bot

Comment 17 2012-07-02 03:55:31 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13132074

Build Bot

Comment 18 2012-07-02 04:03:35 PDT

Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13126149

Andreas Kling

Comment 19 2012-07-02 04:10:08 PDT

Created attachment 150395 [details] Patch

WebKit Review Bot

Comment 20 2012-07-02 06:13:12 PDT

Comment on attachment 150395 [details] Patch Attachment 150395 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13133098 New failing tests: editing/pasteboard/paste-text-002.html editing/pasteboard/paste-text-004.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-008.html

WebKit Review Bot

Comment 21 2012-07-02 06:13:20 PDT

Created attachment 150410 [details] Archive of layout-test-results from gce-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Andreas Kling

Comment 22 2012-07-03 06:11:23 PDT

Created attachment 150594 [details] Patch Okay, let's only do one thing in this patch. It turns out that we have some editing code that relies on inline style declarations floating around headlessly after nuking their parent elements' style attribute. A mess for another day.

WebKit Review Bot

Comment 23 2012-07-05 04:59:45 PDT

Comment on attachment 150594 [details] Patch Rejecting attachment 150594 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: g file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp Hunk #1 FAILED at 132. 1 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp.rej patching file Source/WebCore/css/PropertySetCSSStyleDeclaration.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antti Koiv..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13138939

Andreas Kling

Comment 24 2012-07-06 06:18:37 PDT

Created attachment 151072 [details] Land already

WebKit Review Bot

Comment 25 2012-07-06 10:05:58 PDT

Comment on attachment 151072 [details] Land already Clearing flags on attachment: 151072 Committed r121982: <http://trac.webkit.org/changeset/121982>

WebKit Review Bot

Comment 26 2012-07-06 10:06:04 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.