| Summary: | Separate mutating CSSStyleDeclaration operations. | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||||||||||
| Component: | CSS | Assignee: | Andreas Kling <kling> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | cmarcelo, dglazkov, gustavo, koivisto, macpherson, menard, philn, webkit.review.bot, xan.lopez | ||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Andreas Kling
2012-06-25 23:10:45 PDT
Created attachment 149461 [details]
Patch?
Comment on attachment 149461 [details] Patch? Attachment 149461 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13097369 New failing tests: platform/chromium/compositing/layout-width-change.html platform/chromium/compositing/render-surface-alpha-blending.html platform/chromium/compositing/tiny-layer-rotated.html platform/chromium/compositing/huge-layer-rotated.html fast/loader/loadInProgress.html platform/chromium/compositing/3d-corners.html platform/chromium/compositing/video-frame-size-change.html platform/chromium/compositing/perpendicular-layer-sorting.html fast/loader/unload-form-post-about-blank.html platform/chromium/compositing/child-layer-3d-sorting.html editing/pasteboard/paste-text-002.html platform/chromium/compositing/lost-compositor-context-permanently.html platform/chromium/compositing/lost-compositor-context-with-video.html platform/chromium/compositing/accelerated-drawing/alpha.html http/tests/xmlhttprequest/zero-length-response.html http/tests/security/script-crossorigin-loads-correctly.html platform/chromium/compositing/webgl-loses-compositor-context.html platform/chromium/compositing/backface-visibility-transformed.html platform/chromium/compositing/lost-compositor-context-with-rendersurface.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-008.html platform/chromium/compositing/lost-compositor-context.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-004.html platform/chromium/compositing/img-layer-grow.html platform/chromium/compositing/lost-compositor-context-twice.html Created attachment 149482 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Looks good modulo the test failures. Created attachment 149552 [details]
Patch
Let's give that another go (exactly the same patch) since I don't get any of these failures locally..
Comment on attachment 149552 [details] Patch Attachment 149552 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13099466 New failing tests: editing/pasteboard/paste-text-002.html editing/pasteboard/paste-text-004.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-008.html Created attachment 149571 [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 149552 [details]
Patch
r=me
(In reply to comment #6) > (From update of attachment 149552 [details]) > Attachment 149552 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/13099466 > > New failing tests: > editing/pasteboard/paste-text-002.html > editing/pasteboard/paste-text-004.html > editing/pasteboard/paste-text-003.html > editing/pasteboard/paste-text-005.html > editing/pasteboard/paste-text-008.html Can't reproduce these failures, so I'm just gonna land-it-and-see-what-happens(tm). Committed r121562: <http://trac.webkit.org/changeset/121562> Reverted r121562 for reason: Broke Committed r121570: <http://trac.webkit.org/changeset/121570> Created attachment 150389 [details]
Patch v2
Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13133064 Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13125131 Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13127152 Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13126145 Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13132074 Comment on attachment 150389 [details] Patch v2 Attachment 150389 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13126149 Created attachment 150395 [details]
Patch
Comment on attachment 150395 [details] Patch Attachment 150395 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13133098 New failing tests: editing/pasteboard/paste-text-002.html editing/pasteboard/paste-text-004.html editing/pasteboard/paste-text-003.html editing/pasteboard/paste-text-005.html editing/pasteboard/paste-text-008.html Created attachment 150410 [details]
Archive of layout-test-results from gce-cr-linux-01
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 150594 [details]
Patch
Okay, let's only do one thing in this patch. It turns out that we have some editing code that relies on inline style declarations floating around headlessly after nuking their parent elements' style attribute. A mess for another day.
Comment on attachment 150594 [details] Patch Rejecting attachment 150594 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: g file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp Hunk #1 FAILED at 132. 1 out of 14 hunks FAILED -- saving rejects to file Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp.rej patching file Source/WebCore/css/PropertySetCSSStyleDeclaration.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Antti Koiv..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13138939 Created attachment 151072 [details]
Land already
Comment on attachment 151072 [details] Land already Clearing flags on attachment: 151072 Committed r121982: <http://trac.webkit.org/changeset/121982> All reviewed patches have been landed. Closing bug. |