Bug 89942
| Summary: | Add style check to protect against bad #ifdef usage | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Shawn Singh <shawnsingh> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jamesr, shawnsingh |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Shawn Singh
For example, https://bugs.webkit.org/show_bug.cgi?id=89931 - #ifdef and #if have different behavior if a preprocessor symbol is defined, but its value is "false". To protect against this, one option is to create a style check that complains if someone uses #ifdef with a preprocessor symbol that actually has a value.
What other options should we consider for making a style check about this?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Shawn Singh
bug is obsolete