Bug 8994

Summary: Canvas doesn't reset on resize
Product: WebKit Reporter: Ian 'Hixie' Hickson <ian>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ian
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://hixie.ch/tests/adhoc/html/canvas/017.html
Attachments:
Description Flags
First attempt darin: review+

Ian 'Hixie' Hickson
Reported 2006-05-19 07:52:15 PDT
Resizing the canvas coordinate space (changing the height and width attributes) should reset the canvas bitmap to transparent black and the context to its initial state. The lineWidth currently doesn't seem to get reset. TESTCASES http://hixie.ch/tests/adhoc/html/canvas/017.html http://hixie.ch/tests/adhoc/html/canvas/018.html http://hixie.ch/tests/adhoc/html/canvas/019.html
Attachments
First attempt (14.62 KB, patch)
2007-07-07 07:16 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ivo Beckers
Comment 1 2006-07-24 02:56:27 PDT
The entire CANVAS element becomes unusable after changing the width and height on the fly. A complete swap of the element with its new dimensions is necessary to bring it back to live.
Ivo Beckers
Comment 2 2006-07-24 02:58:47 PDT
The entire CANVAS element becomes unusable after changing its width,height on the fly. A complete swap of the element with the new dimensions is necessary to bring it back to live again.
Rob Buis
Comment 3 2007-07-07 07:16:19 PDT
Created attachment 15432 [details] First attempt This should fix the problem. Cheers, Rob.
Darin Adler
Comment 4 2007-07-07 09:33:20 PDT
Comment on attachment 15432 [details] First attempt You shouldn't need to say .get() to check a RefPtr for null. Also, the indentation is 4 spaces, not 3. r=me
Darin Adler
Comment 5 2007-07-07 13:16:30 PDT
Committed revision 24090.
Note You need to log in before you can comment on or make changes to this bug.