Bug 89891

Summary: Web Inspector: StyleSource should set content using CSSStyleModelResourceBinding directly.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 89868    
Attachments:
Description Flags
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-06-25 10:23:24 PDT
StyleSource should set content using CSSStyleModelResourceBinding directly. It should not use resource.setContent method. Also revision should not be added before setStyleSheetText returns from backend to keep UISourceCode in consistent state.
Attachments
Patch (8.26 KB, patch)
2012-06-26 02:44 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-06-26 02:44:59 PDT
Created attachment 149497 [details] Patch
Pavel Feldman
Comment 2 2012-06-29 22:37:29 PDT
Comment on attachment 149497 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=149497&action=review > Source/WebCore/ChangeLog:10 > + Resource.revertAndClearHistory is now clearing history asynchronously I think we should rather not create revision for revert at all.
Vsevolod Vlasov
Comment 3 2012-07-02 00:43:29 PDT
Comment on attachment 149497 [details] Patch I would not add a boolean flag to several methods only because of revert functionality only since we are planning to move to synchronous revision adding anyway,
Vsevolod Vlasov
Comment 4 2012-07-02 05:13:35 PDT
Committed r121672: <http://trac.webkit.org/changeset/121672>
Note You need to log in before you can comment on or make changes to this bug.