Bug 89866

Summary: Add static qualifier to GraphicsContext3D::extractImageData.
Product: WebKit Reporter: Dongseong Hwang <dongseong.hwang>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, mrobinson, noam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 89867    
Attachments:
Description Flags
patch
none
patch v.2 none

Description Dongseong Hwang 2012-06-25 04:19:20 PDT 
GraphicsContext3D::extractImageData does not use member variables.
Each platform Accelerated-compositing implementation can use this method in order to get pixel data of an Image or ImageBuffer object.
Comment 1 Dongseong Hwang 2012-06-25 04:21:06 PDT 
Created attachment 149271 [details]
patch
Comment 2 WebKit Review Bot 2012-06-25 04:25:15 PDT 
Attachment 149271 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/GraphicsContext3D.h:570:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/graphics/GraphicsContext3D.h:891:  The parameter name "image" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dongseong Hwang 2012-06-25 04:34:10 PDT 
Created attachment 149274 [details]
patch v.2
Comment 4 Dongseong Hwang 2012-06-25 04:42:03 PDT 
I amended Texmap to use  GraphicsContext3D::extractImageData in Bug 89867.
Comment 5 Noam Rosenthal 2012-06-25 06:16:00 PDT 
I think this is fine. mrobinson/kbr, any issue with this?
Comment 6 Martin Robinson 2012-06-25 08:26:09 PDT 
This seems like a reasonable change to me.
Comment 7 Kenneth Russell 2012-06-25 08:27:15 PDT 
Comment on attachment 149274 [details]
patch v.2

Seems fine as long as it compiles.
Comment 8 Noam Rosenthal 2012-06-25 08:27:44 PDT 
Comment on attachment 149274 [details]
patch v.2

LGTM
Comment 9 WebKit Review Bot 2012-06-25 08:40:57 PDT 
Comment on attachment 149274 [details]
patch v.2

Clearing flags on attachment: 149274

Committed r121159: <http://trac.webkit.org/changeset/121159>
Comment 10 WebKit Review Bot 2012-06-25 08:41:03 PDT 
All reviewed patches have been landed.  Closing bug.