Bug 8984
| Summary: | Add arguments to the custom functions in CanvasRenderingContext2D | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, bfulgham, eric, ian, mdelaney7, rniwa |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
Anders Carlsson
The functions
[Custom] void setStrokeColor(/* 1 */);
[Custom] void setFillColor(/* 1 */);
[Custom] void strokeRect(/* 4 */);
[Custom] void drawImage(/* 3 */);
[Custom] void drawImageFromRect(/* 10 */);
[Custom] void setShadow(/* 3 */);
[Custom] void createPattern(/* 2 */);
should have the correct number of arguments specified. The type doesn't matter since it's ignored when using a custom implementation
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
*** Bug 16969 has been marked as a duplicate of this bug. ***
Ahmad Saleem
@rniwa - Is this something needed? I tried to find any Canvas related test on WPT.FYI under DOM but couldn't find any.
Alexey Proskuryakov
This was not about making any observable change, but about how Source/WebCore//html/canvas/CanvasRenderingContext2D.idl was written.
None of these functions are Custom any more, and of course all have their arguments spelled out.