Bug 89834

Summary:

Web Inspector: toggling style should not start property edit first.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-01	none
[Patch] For bots	none

Pavel Feldman

Reported 2012-06-24 12:24:34 PDT

Otherwise property flickers upon toggling.

Attachments
Patch (1.89 KB, patch) 2012-06-24 12:28 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-01 (714.57 KB, application/zip) 2012-06-24 18:13 PDT, WebKit Review Bot	no flags	Details
[Patch] For bots (7.82 KB, patch) 2012-06-24 22:05 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2012-06-24 12:28:32 PDT

Created attachment 149201 [details] Patch

WebKit Review Bot

Comment 2 2012-06-24 18:13:49 PDT

Comment on attachment 149201 [details] Patch Attachment 149201 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13093002 New failing tests: inspector/styles/styles-disable-then-change.html inspector/styles/styles-disable-then-enable.html inspector/styles/undo-property-toggle.html inspector/styles/styles-disable-inherited.html inspector/styles/styles-disable-then-delete.html

WebKit Review Bot

Comment 3 2012-06-24 18:13:53 PDT

Created attachment 149217 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Feldman

Comment 4 2012-06-24 22:05:30 PDT

Created attachment 149238 [details] [Patch] For bots

WebKit Review Bot

Comment 5 2012-06-25 07:36:15 PDT

Comment on attachment 149238 [details] [Patch] For bots Clearing flags on attachment: 149238 Committed r121156: <http://trac.webkit.org/changeset/121156>

WebKit Review Bot

Comment 6 2012-06-25 07:36:20 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.