Bug 89834

Summary: Web Inspector: toggling style should not start property edit first.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ec2-cr-linux-01
none
[Patch] For bots none

Description Pavel Feldman 2012-06-24 12:24:34 PDT
Otherwise property flickers upon toggling.
Comment 1 Pavel Feldman 2012-06-24 12:28:32 PDT
Created attachment 149201 [details]
Patch
Comment 2 WebKit Review Bot 2012-06-24 18:13:49 PDT
Comment on attachment 149201 [details]
Patch

Attachment 149201 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13093002

New failing tests:
inspector/styles/styles-disable-then-change.html
inspector/styles/styles-disable-then-enable.html
inspector/styles/undo-property-toggle.html
inspector/styles/styles-disable-inherited.html
inspector/styles/styles-disable-then-delete.html
Comment 3 WebKit Review Bot 2012-06-24 18:13:53 PDT
Created attachment 149217 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Pavel Feldman 2012-06-24 22:05:30 PDT
Created attachment 149238 [details]
[Patch] For bots
Comment 5 WebKit Review Bot 2012-06-25 07:36:15 PDT
Comment on attachment 149238 [details]
[Patch] For bots

Clearing flags on attachment: 149238

Committed r121156: <http://trac.webkit.org/changeset/121156>
Comment 6 WebKit Review Bot 2012-06-25 07:36:20 PDT
All reviewed patches have been landed.  Closing bug.