Bug 89823

Summary: Remove unused constant timeWithoutMouseMovementBeforeHidingControls
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dbates, eric.carlson, feature-media-reviews, jer.noble, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2012-06-23 22:53:27 PDT
After r87692, timeWithoutMouseMovementBeforeHidingControls is not used anymore.
Attachments
Patch (1.38 KB, patch)
2012-06-23 22:55 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2012-06-23 22:55:41 PDT
Created attachment 149185 [details] Patch
Daniel Bates
Comment 2 2012-06-25 11:01:48 PDT
For completeness, the patch for bug #61717 moved the HTMLMediaElement code to MediaControlRootElement. In particular, the function startHideFullscreenControlsTimer() in HTMLMediaElement.cpp (which was the only function that referenced timeWithoutMouseMovementBeforeHidingControls in HTMLMediaElement.cpp) was moved to MediaControlRootElement.cpp, but the constant timeWithoutMouseMovementBeforeHidingControls in HTMLMediaElement.cpp wasn't removed.
Daniel Bates
Comment 3 2012-06-25 11:02:06 PDT
Comment on attachment 149185 [details] Patch r=me
WebKit Review Bot
Comment 4 2012-06-25 11:56:37 PDT
Comment on attachment 149185 [details] Patch Clearing flags on attachment: 149185 Committed r121173: <http://trac.webkit.org/changeset/121173>
WebKit Review Bot
Comment 5 2012-06-25 11:56:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.