Bug 89818 – Inspector crashes when trying to inspect a page with CSS variables

• Component: CSS
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

1) Go to URL above
2) Try to inspect the element that has CSS Variables applied to it
3) ... boom.

[Luke Macpherson]

Are you using a custom build with --css-variables to reproduce this?

[Dimitri Glazkov (Google)]

(In reply to comment #1)
> Are you using a custom build with --css-variables to reproduce this?

Yup.

[Luke Macpherson]

Created attachment 149414 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 149414 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=149414&action=review

> Source/WebCore/css/CSSParser.cpp:2974
> +    printf("storing variable name \"%s\"\n", tmp.ascii().data());

printf :)

[Dimitri Glazkov (Google)]

Pavel, can you help Luke with the test for this?

[Luke Macpherson]

Created attachment 149441 [details]
Patch

[Pavel Feldman]

(In reply to comment #5)
> Pavel, can you help Luke with the test for this?

There is a bunch of these under LayoutTests/inspector/styles. You'll probably want to land them disabled until your feature is enabled (oh how do we handle these cases?). Adding apavlov@ for additional help.

[Luke Macpherson]

Created attachment 150061 [details]
Patch

[Luke Macpherson]

Created attachment 150063 [details]
Patch

[Luke Macpherson]

Last patch adds a test to inspector, but we still need to disable that test if CSS_VARIABLES compile flag is off. One option would be to just move that test under fast/css/variables, where it will be ignored unless the flag is on.

[WebKit Review Bot]

Comment on attachment 150063 [details]
Patch

Attachment 150063 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13119219

New failing tests:
inspector/styles/css-variables.html

[WebKit Review Bot]

Created attachment 150083 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Alexander Pavlov (apavlov)]

(In reply to comment #10)
> Last patch adds a test to inspector, but we still need to disable that test if CSS_VARIABLES compile flag is off. One option would be to just move that test under fast/css/variables, where it will be ignored unless the flag is on.

Since inspector tests require special setup, and they are filtered by the "/inspector" file URL part, I believe it's easier to add a directory like "LayoutTests/inspector/variables" to the result of _missing_symbol_to_skipped_tests() for the "CSSVariableValue" key (in Tools/Scripts/webkitpy/layout_tests/port/webkit.py) and get the benefit of the web inspector tests run only with the css variables enabled.

[Luke Macpherson]

Created attachment 150353 [details]
Patch

[WebKit Review Bot]

Comment on attachment 150353 [details]
Patch

Attachment 150353 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13133092

New failing tests:
fast/loader/loadInProgress.html

[WebKit Review Bot]

Created attachment 150403 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Luke Macpherson]

Created attachment 150498 [details]
Same Patch - retry on bots.

[Luke Macpherson]

I can haz r+?

[WebKit Review Bot]

Comment on attachment 150498 [details]
Same Patch - retry on bots.

Clearing flags on attachment: 150498

Committed r121874: <http://trac.webkit.org/changeset/121874>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.