Bug 89789
| Summary: | [Chromium] Layout tests plugins/embed-attributes-style.html and userscripts/user-script-video-document.html failing on Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
| Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jsbell, schenney, stuartmorgan, wjmaclean |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Kenneth Russell
Support for the QuickDraw drawing model was removed from Chrome in http://src.chromium.org/viewvc/chrome?view=rev&revision=143721 . At that point layout test plugins/embed-attributes-style.html started failing:
15:21:52.992 1210 worker/0 plugins/embed-attributes-style.html output stderr lines:
15:21:52.992 1210 [2542:-1609747136:1105294615546:ERROR:webplugin_impl.cc(269)] Couldn't initialize plug-in
15:21:52.992 1210 [2542:-1609747136:1105297887668:ERROR:webplugin_impl.cc(269)] Couldn't initialize plug-in
15:21:52.992 1210 [2542:-1609747136:1105303783356:ERROR:webplugin_impl.cc(269)] Couldn't initialize plug-in
15:21:53.071 1210 "/Volumes/data/b/build/slave/Webkit_Mac10_6/build/src/xcodebuild/Release/ImageDiff --diff /tmp/tmpcBq_Uv/actual.png /tmp/tmpcBq_Uv/expected.png /tmp/tmpcBq_Uv/diff.png" took 0.08s
15:21:53.080 1196 plugins/embed-attributes-style.html -> unexpected image mismatch
15:21:53.079 1210 worker/0 plugins/embed-attributes-style.html failed:
15:21:53.079 1210 worker/0 Image mismatch
Presumably the test plugin is requesting the QuickDraw drawing model. Given that this is the only plugin test failing, I think it should be possible to fix up the test.
Marking the test as a known failure in TestExpectations for the moment.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
First failures on canary bots:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/18426
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/13417
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.7/builds/7850
Kenneth Russell
Committed r121065: <http://trac.webkit.org/changeset/121065>
Kenneth Russell
userscripts/user-script-video-document.html is failing similarly on the 10.5 debug bot. Marking as known crash.
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%282%29/builds/8209
16:19:12.466 1285 worker/3 userscripts/user-script-video-document.html crashed, stack trace:
16:19:12.466 1285 [2035:-1603913952:2411030065865:ERROR:webplugin_impl.cc(269)] Couldn't initialize plug-in
16:19:12.466 1285 ASSERTION FAILED: m_frame->document()->parsing()
16:19:12.466 1285 /Volumes/data/b/build/slave/webkit-mac-latest-dbg/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../loader/DocumentLoader.cpp(352) : void WebCore::DocumentLoader::commitData(const char *, size_t)
16:19:12.466 1285 1 0x72962184 start
16:19:12.467 1285 2 0x6fb9111d start
16:19:12.467 1285 3 0x6fb08b17 start
16:19:12.467 1285 4 0x729622db start
16:19:12.467 1285 5 0x72962579 start
16:19:12.467 1285 6 0x729bc934 start
16:19:12.467 1285 7 0x729e1100 start
16:19:12.467 1285 8 0x729be29f start
16:19:12.467 1285 9 0x729e1d7e start
16:19:12.467 1285 10 0x71f4e60f start
16:19:12.467 1285 11 0x73b35f3c webkit::npapi::CarbonPluginWindowTracker::DestroyDummyWindowForDelegate(void*, OpaqueWindowPtr*)
16:19:12.467 1285 12 0x73ce589f webkit::npapi::CarbonPluginWindowTracker::DestroyDummyWindowForDelegate(void*, OpaqueWindowPtr*)
16:19:12.467 1285 13 0x73ce5f52 webkit::npapi::CarbonPluginWindowTracker::DestroyDummyWindowForDelegate(void*, OpaqueWindowPtr*)
16:19:12.467 1285 14 0x73ce5e7f webkit::npapi::CarbonPluginWindowTracker::DestroyDummyWindowForDelegate(void*, OpaqueWindowPtr*)
16:19:12.467 1285 15 0x73ce5df4 webkit::npapi::CarbonPluginWindowTracker::DestroyDummyWindowForDelegate(void*, OpaqueWindowPtr*)
16:19:12.467 1285 16 0x7028c8ab start
16:19:12.467 1285 17 0x70289de8 start
16:19:12.467 1285 18 0x7028a191 start
16:19:12.467 1285 19 0x7028a3d2 start
16:19:12.467 1285 20 0x701f02bb start
16:19:12.467 1285 21 0x701efaf2 start
16:19:12.467 1285 22 0x950433c5 CFRunLoopRunSpecific
16:19:12.467 1285 23 0x95043aa8 CFRunLoopRunInMode
16:19:12.467 1285 24 0x91bda2ac BlockUntilNextEventMatchingListInMode
16:19:12.467 1285 25 0x91bda0c5 BlockUntilNextEventMatchingListInMode
16:19:12.467 1285 26 0x91bd9f39 BlockUntilNextEventMatchingListInMode
16:19:12.467 1285 27 0x93e396d5 _DPSNextEvent
16:19:12.467 1285 28 0x93e38f88 _NSUpdateMenuRefWithChangedMenuItem
16:19:12.467 1285 29 0x93e31f9f _NSSetViewMultiClipDrawingHelper
16:19:12.467 1285 30 0x701f11ee start
16:19:12.468 1285 31 0x701f00f2 start
16:19:12.468 1285 [2035:-1603913952:2411272442997:ERROR:process_util_posix.cc(143)] Received signal 11
16:19:12.475 1269 userscripts/user-script-video-document.html -> unexpected crash
Stuart Morgan
> layout test plugins/embed-attributes-style.html started failing
Hm, this uses the QuickTime plugin, which should use Core Animation and be fine on 10.6+. Oh, but do we run this test binary with OSMesa and thus not have CA support? Or are these tests run in a simplified host that doesn't use Chromium's model negotiation?
If it's the former, maybe we should add wmode="transparent" to the QuickTime embed; that should cause it to use CG mode.
Alternately, it's not clear to me why this test uses QuickTime in the first place, so perhaps the better approach would be to make it use the normal test plugin instead of relying on a specific plugin.
> userscripts/user-script-video-document.html is failing similarly on the 10.5 debug bot.
QuickTime simply won't run on 10.5 any more, so this is expected. We should presumably be shutting down the 10.5 testers anyway.
Stuart Morgan
(In reply to comment #4)
> Alternately, it's not clear to me why this test uses QuickTime in the first place, so perhaps the better approach would be to make it use the normal test plugin instead of relying on a specific plugin.
I don't have a WebKit tree set up, and I'm not sure when I'll have to set one up. If someone who does could try changing this test to use the test plugin and see if it works (we'd have to change the expected.png obviously), that would be awesome.
Joshua Bell
userscripts/user-script-video-document.html has started failing on Win7 debug as well:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=userscripts%2Fuser-script-video-document.html
Updating the test expectation for that one, also scoping it to Debug.
noel gordon
*** Bug 91445 has been marked as a duplicate of this bug. ***