Bug 89784

Summary: [chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
Product: WebKit Reporter: vollick
Component: WebCore Misc.Assignee: vollick
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, hclam, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

vollick
Reported 2012-06-22 14:31:33 PDT
Previously, we'd only set needs redraw if the old bounds were zero and the new bounds were non-empty. The check really should have been if the old bounds were empty and the new bounds non-empty.
Attachments
Patch (3.45 KB, patch)
2012-06-22 14:34 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Patch (3.46 KB, patch)
2012-06-25 20:17 PDT, vollick 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
vollick
Comment 1 2012-06-22 14:34:27 PDT
Created attachment 149102 [details] Patch
James Robinson
Comment 2 2012-06-22 14:54:54 PDT
Comment on attachment 149102 [details] Patch R=me (when did this show up, out of curiosity?)
vollick
Comment 3 2012-06-25 12:45:17 PDT
(In reply to comment #2) > (From update of attachment 149102 [details]) > R=me (when did this show up, out of curiosity?) We started to see this on a page with an accelerated transition. The texture was meant to get bounds of 250x250, but on the way from zero bounds, it got set to 250x0 for a moment before getting the real bounds. When this happened we never setNeedsDisplay, and the texture never appeared.
WebKit Review Bot
Comment 4 2012-06-25 13:19:49 PDT
Comment on attachment 149102 [details] Patch Clearing flags on attachment: 149102 Committed r121178: <http://trac.webkit.org/changeset/121178>
WebKit Review Bot
Comment 5 2012-06-25 13:19:54 PDT
All reviewed patches have been landed. Closing bug.
Hin-Chung Lam
Comment 6 2012-06-25 15:46:00 PDT
Reverted r121178 for reason: New unit test added is failing on WebKit Linux (dbg) Committed r121190: <http://trac.webkit.org/changeset/121190>
Hin-Chung Lam
Comment 7 2012-06-25 15:46:37 PDT
(In reply to comment #6) > Reverted r121178 for reason: > > New unit test added is failing on WebKit Linux (dbg) > > Committed r121190: <http://trac.webkit.org/changeset/121190> See the failure log here: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/8404
vollick
Comment 8 2012-06-25 20:17:02 PDT
Created attachment 149440 [details] Patch Fix unit test.
WebKit Review Bot
Comment 9 2012-06-26 11:42:45 PDT
Comment on attachment 149440 [details] Patch Clearing flags on attachment: 149440 Committed r121273: <http://trac.webkit.org/changeset/121273>
WebKit Review Bot
Comment 10 2012-06-26 11:42:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.