Bug 89749 – [EFL][WK2] Add API to inspect a Web Intent

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

The WK2 C API to inspect a Web Intent recently landed in Bug 89275. We now need to provide an Ewk wrapper in WK2 EFL port.

[Chris Dumez]

Created attachment 148982 [details]
Patch

[Chris Dumez]

Informal review anyone?

[Gyuyoung Kim]

Comment on attachment 148982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148982&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_intent.h:25
> +

It is good to write file description.

> Source/WebKit2/UIProcess/API/efl/ewk_intent.h:115
> +EAPI char *ewk_intent_extra_get(const Ewk_Intent *intent, const char *key);

I wonder why this APIs doesn't use const char* as other APIs. Is there any reason ?

[Chris Dumez]

Comment on attachment 148982 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148982&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_intent.h:115
>> +EAPI char *ewk_intent_extra_get(const Ewk_Intent *intent, const char *key);
> 
> I wonder why this APIs doesn't use const char* as other APIs. Is there any reason ?

This is because using stringsharing is not easy in this case, since we have a hash table.

[Chris Dumez]

Created attachment 149688 [details]
Patch

Add missing file description for ewk_intent.h.

[Gyuyoung Kim]

Comment on attachment 149688 [details]
Patch

Looks good to me.

[Chris Dumez]

Created attachment 149896 [details]
Patch

- No longer ignores intent requests coming from other frames than the main one.
- Fix signal name. It is now "intent,request,new" instead of "title,changed" (bad copy / paste).
- Rename ewk_view_intent_new() to ewk_view_intent_request_new() for clarity.

[Chris Dumez]

Created attachment 150110 [details]
Patch

Rebase on master.

[Kenneth Rohde Christiansen]

Comment on attachment 150110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150110&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:46
> +struct _Ewk_Intent {
> +    unsigned int __ref; /**< the reference count of the object */

ieck manual ref counting :-(

> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:149
> +char* ewk_intent_extra_get(const Ewk_Intent* intent, const char* key)

extra what? :-) additional_metadata ? Or is this part of the spec?

[Chris Dumez]

Comment on attachment 150110 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=150110&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:46
>> +    unsigned int __ref; /**< the reference count of the object */
> 
> ieck manual ref counting :-(

I copied the style used in other Ewk classes.

>> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:149
>> +char* ewk_intent_extra_get(const Ewk_Intent* intent, const char* key)
> 
> extra what? :-) additional_metadata ? Or is this part of the spec?

It is part of the spec, yes: http://www.w3.org/TR/web-intents/#methods

[WebKit Review Bot]

Comment on attachment 150110 [details]
Patch

Clearing flags on attachment: 150110

Committed r121649: <http://trac.webkit.org/changeset/121649>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.