Summary: | [EFL][WK2] Add API to inspect a Web Intent | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kenneth, rakuco, ryuan.choi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 89275 | ||||||||||||
Bug Blocks: | 90064 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2012-06-22 01:43:35 PDT
Created attachment 148982 [details]
Patch
Informal review anyone? Comment on attachment 148982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148982&action=review > Source/WebKit2/UIProcess/API/efl/ewk_intent.h:25 > + It is good to write file description. > Source/WebKit2/UIProcess/API/efl/ewk_intent.h:115 > +EAPI char *ewk_intent_extra_get(const Ewk_Intent *intent, const char *key); I wonder why this APIs doesn't use const char* as other APIs. Is there any reason ? Comment on attachment 148982 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148982&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_intent.h:115 >> +EAPI char *ewk_intent_extra_get(const Ewk_Intent *intent, const char *key); > > I wonder why this APIs doesn't use const char* as other APIs. Is there any reason ? This is because using stringsharing is not easy in this case, since we have a hash table. Created attachment 149688 [details]
Patch
Add missing file description for ewk_intent.h.
Comment on attachment 149688 [details]
Patch
Looks good to me.
Created attachment 149896 [details]
Patch
- No longer ignores intent requests coming from other frames than the main one.
- Fix signal name. It is now "intent,request,new" instead of "title,changed" (bad copy / paste).
- Rename ewk_view_intent_new() to ewk_view_intent_request_new() for clarity.
Created attachment 150110 [details]
Patch
Rebase on master.
Comment on attachment 150110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150110&action=review > Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:46 > +struct _Ewk_Intent { > + unsigned int __ref; /**< the reference count of the object */ ieck manual ref counting :-( > Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:149 > +char* ewk_intent_extra_get(const Ewk_Intent* intent, const char* key) extra what? :-) additional_metadata ? Or is this part of the spec? Comment on attachment 150110 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150110&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:46 >> + unsigned int __ref; /**< the reference count of the object */ > > ieck manual ref counting :-( I copied the style used in other Ewk classes. >> Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp:149 >> +char* ewk_intent_extra_get(const Ewk_Intent* intent, const char* key) > > extra what? :-) additional_metadata ? Or is this part of the spec? It is part of the spec, yes: http://www.w3.org/TR/web-intents/#methods Comment on attachment 150110 [details] Patch Clearing flags on attachment: 150110 Committed r121649: <http://trac.webkit.org/changeset/121649> All reviewed patches have been landed. Closing bug. |