Bug 89746 – Replace isolate || bidi-override by isolate-override

• Component: CSS
• Status: RESOLVED FIXED

[Ryosuke Niwa]

fantasai says:
Change made, per WG resolution and me being convinced by trying to explain
the issue to the WG. :)

http://lists.w3.org/Archives/Public/www-style/2012May/0541.html
http://dev.w3.org/csswg/css3-writing-modes/#unicode-bidi

so we should update our implementation.

[Aharon (Vladimir) Lanin]

FYI, this has been done in Mozilla (https://bugzilla.mozilla.org/show_bug.cgi?id=774335)

[Ryosuke Niwa]

Created attachment 159514 [details]
Fixes the bug

[Levi Weintraub]

Comment on attachment 159514 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=159514&action=review

LGTM

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-1203
> -static PassRefPtr<CSSValue> renderUnicodeBidiFlagsToCSSValue(EUnicodeBidi unicodeBidi)
> -{
> -    switch (unicodeBidi) {
> -    case UBNormal:
> -        return cssValuePool().createIdentifierValue(CSSValueNormal);
> -    case Embed:
> -        return cssValuePool().createIdentifierValue(CSSValueEmbed);
> -    case Plaintext:
> -        return cssValuePool().createIdentifierValue(CSSValueWebkitPlaintext);
> -    case Override:
> -        return cssValuePool().createIdentifierValue(CSSValueBidiOverride);
> -    case Isolate:
> -        return cssValuePool().createIdentifierValue(CSSValueWebkitIsolate);
> -    case OverrideIsolate:
> -    {
> -        RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();
> -        list->append(cssValuePool().createIdentifierValue(CSSValueBidiOverride));
> -        list->append(cssValuePool().createIdentifierValue(CSSValueWebkitIsolate));
> -        return list;
> -    }
> -    }
> -    ASSERT_NOT_REACHED();
> -    return 0;
> -}
> -

Woohoo!

> LayoutTests/fast/text/bidi-override-isolate.html:-13
> -<div><span style="direction: rtl; unicode-bidi: -webkit-isolate -webkit-isolate; unicode-bidi: isolate isolate;

Was this just a copy-paste mistake?

[Ryosuke Niwa]

(In reply to comment #3)
> (From update of attachment 159514 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159514&action=review
>
> > LayoutTests/fast/text/bidi-override-isolate.html:-13
> > -<div><span style="direction: rtl; unicode-bidi: -webkit-isolate -webkit-isolate; unicode-bidi: isolate isolate;
> 
> Was this just a copy-paste mistake?

No, it was testing the case where the same value appears twice.

[Ryosuke Niwa]

Committed r126072: <http://trac.webkit.org/changeset/126072>