| Summary: | [Chromium] DumpRenderTree on Android needs to configure fonts for testing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | dpranke, japhet, jnd, ojan, peter, tkent, webkit.review.bot, zhenghao | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 66687 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Adam Barth
2012-06-21 17:43:20 PDT
Created attachment 148923 [details]
Patch
Comment on attachment 148923 [details]
Patch
Missed a couple.
Created attachment 148934 [details]
Patch
Comment on attachment 148934 [details]
Patch
LGTM for the WebKit side, but please do not commit this until the SkUseTestFontConfigFile API has landed in Skia and has rolled to Chromium, then to WebKit, none of which is the case as of yet.
Peter, is there a bug I can track to see when that happens? I'm tempted to land this with the call to SkUseTestFontConfigFile commented out until the API is available. (In reply to comment #6) > I'm tempted to land this with the call to SkUseTestFontConfigFile commented out until the API is available. What sort of time scale are we looking at for SkUseTestFontConfigFile to become available? Created attachment 149063 [details]
Patch for landing
> What sort of time scale are we looking at for SkUseTestFontConfigFile to become available?
Looks like the chromium-android branch has a 79 line diff to Skia, of which this change accounts for all but 7.
Maybe we should try contributing that patch to Skia ourselves? It's all in Android-specific files.
Comment on attachment 149063 [details]
Patch for landing
I think it's ok to land this patch with the call to SkUseTestFontConfigFile commented out. We're going to drive the Skia side of this change to completion, so we might as well have this code upstream.
Agreed, though I'd prefer to attach a bug to the FIXME so it's easier to keep track of. Not that I have any doubt about you following up, of course :). I filed Bug 89801 about this topic. Created attachment 149155 [details]
Patch for landing
Comment on attachment 149155 [details] Patch for landing Clearing flags on attachment: 149155 Committed r121086: <http://trac.webkit.org/changeset/121086> All reviewed patches have been landed. Closing bug. *** Bug 87006 has been marked as a duplicate of this bug. *** |