| Summary: | Prep work for gradient interpolation. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shane Stephens <shanestephens> | ||||||||
| Component: | CSS | Assignee: | Shane Stephens <shanestephens> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | bfulgham, cmarcelo, eric, hyatt, macpherson, menard, morrita, pdr, simon.fraser, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 21725 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Shane Stephens
2012-06-21 00:20:27 PDT
Created attachment 148741 [details]
Patch
Attachment 148741 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 148741 [details] Patch Attachment 148741 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13026050 Created attachment 148914 [details]
Patch
Is this still valid? It should be, but it's probably out of date. If someone is willing to review, I'm very happy to bring the patch up-to-date with the tree. Comment on attachment 148914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148914&action=review > It should be, but it's probably out of date. If someone is willing to review, I'm very happy to bring the patch up-to-date with the tree. The code basically looks fine. So I'm happy to help. Let's iterate a bit more. > Source/WebCore/css/CSSGradientValue.cpp:579 > +float CSSLinearGradientValue::angleInDegrees() const It's better to have this change when we actually use this. Otherwise we have code with no test coverage, which is bad. Comment on attachment 148914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148914&action=review > Source/WebCore/ChangeLog:23 > + (WebCore::CSSGradientValue::canBlendWith): Returns true iff two gradients can be interpolated. s/iff/if/ Created attachment 172476 [details]
Patch
Comment on attachment 172476 [details] Patch Attachment 172476 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14744330 |