Bug 89638

Summary:

Prep work for gradient interpolation.

Product:

WebKit

Reporter:

Shane Stephens <shanestephens>

Component:

CSS

Assignee:

Shane Stephens <shanestephens>

Status:

NEW

Severity:

Normal

CC:

bfulgham, cmarcelo, eric, hyatt, macpherson, menard, morrita, pdr, simon.fraser, webkit.review.bot

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

21725

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	morrita: review+, eflews.bot: commit-queue-

Shane Stephens

Reported 2012-06-21 00:20:27 PDT

Prep work for gradient interpolation.

Attachments
Patch (12.41 KB, patch) 2012-06-21 00:29 PDT, Shane Stephens	no flags	Details Formatted Diff Diff
Patch (12.42 KB, patch) 2012-06-21 17:05 PDT, Shane Stephens	no flags	Details Formatted Diff Diff
Patch (8.93 KB, patch) 2012-11-05 20:14 PST, Shane Stephens	morrita: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Shane Stephens

Comment 1 2012-06-21 00:29:31 PDT

Created attachment 148741 [details] Patch

WebKit Review Bot

Comment 2 2012-06-21 00:32:14 PDT

Attachment 148741 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 3 2012-06-21 01:12:13 PDT

Comment on attachment 148741 [details] Patch Attachment 148741 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13026050

Shane Stephens

Comment 4 2012-06-21 17:05:53 PDT

Created attachment 148914 [details] Patch

Hajime Morrita

Comment 5 2012-11-04 17:16:05 PST

Is this still valid?

Shane Stephens

Comment 6 2012-11-04 18:44:28 PST

It should be, but it's probably out of date. If someone is willing to review, I'm very happy to bring the patch up-to-date with the tree.

Hajime Morrita

Comment 7 2012-11-04 18:54:01 PST

Comment on attachment 148914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148914&action=review > It should be, but it's probably out of date. If someone is willing to review, I'm very happy to bring the patch up-to-date with the tree. The code basically looks fine. So I'm happy to help. Let's iterate a bit more. > Source/WebCore/css/CSSGradientValue.cpp:579 > +float CSSLinearGradientValue::angleInDegrees() const It's better to have this change when we actually use this. Otherwise we have code with no test coverage, which is bad.

Dirk Schulze

Comment 8 2012-11-05 07:10:48 PST

Comment on attachment 148914 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148914&action=review > Source/WebCore/ChangeLog:23 > + (WebCore::CSSGradientValue::canBlendWith): Returns true iff two gradients can be interpolated. s/iff/if/

Shane Stephens

Comment 9 2012-11-05 20:14:28 PST

Created attachment 172476 [details] Patch

EFL EWS Bot

Comment 10 2012-11-05 22:55:22 PST

Comment on attachment 172476 [details] Patch Attachment 172476 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14744330

Note You need to log in before you can comment on or make changes to this bug.