Bug 89618

Summary: Unskip fast/hidpi/device-scale-factor-paint.html
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric, jamesr, tdanderson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2012-06-20 17:09:49 PDT
Unskip fast/hidpi/device-scale-factor-paint.html
Comment 1 Adam Barth 2012-06-20 17:11:48 PDT
Created attachment 148684 [details]
Patch
Comment 2 Adam Barth 2012-06-20 17:12:55 PDT
Created attachment 148685 [details]
Patch
Comment 3 Adam Barth 2012-06-20 17:35:09 PDT
tdanserson: Notice that apple-mac seems to produce large PNGs for these hidpi test results.  I'm not sure what all is involved in teaching Chromium's DRT to produce big PNGs.
Comment 4 WebKit Review Bot 2012-06-20 18:29:53 PDT
Comment on attachment 148685 [details]
Patch

Clearing flags on attachment: 148685

Committed r120894: <http://trac.webkit.org/changeset/120894>
Comment 5 WebKit Review Bot 2012-06-20 18:29:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Terry Anderson 2012-06-21 11:35:48 PDT
(In reply to comment #3)
> tdanserson: Notice that apple-mac seems to produce large PNGs for these hidpi test results.  I'm not sure what all is involved in teaching Chromium's DRT to produce big PNGs.

I thought we had agreed that we would be keeping the PNGs at the normal 800x600 size, which would show just the top left quadrant of the image.
Comment 7 Adam Barth 2012-06-21 12:06:17 PDT
> I thought we had agreed that we would be keeping the PNGs at the normal 800x600 size, which would show just the top left quadrant of the image.

If we go that route, we should convert these tests to that format as well.   On the other hand, it might be easier to build on what we have already.  In any case, we should end up with this working the same way for every port.