Bug 8958

Summary: Should be able to have custom implementations for JS methods
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebCore Misc.Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Add [Custom] keyword and port JSCanvasRenderingContext2D over to it mjs: review+

Anders Carlsson
Reported 2006-05-17 12:11:01 PDT
...currently we do this by adding an extra object in the prototype chain.
Attachments
Add [Custom] keyword and port JSCanvasRenderingContext2D over to it (50.18 KB, patch)
2006-05-17 12:16 PDT, Anders Carlsson 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2006-05-17 12:16:50 PDT
Created attachment 8368 [details] Add [Custom] keyword and port JSCanvasRenderingContext2D over to it There are two things I'm unsure about with this patch: * The custom functions in CanvasRenderingContext2D are vararg functions, and I've indicated this by adding /* ... */ as arguments to them. The problem with this is that the length property of the function won't be correct. * I don't like the "custom" type that's used for properties. Perhaps "object" or "any" is a better choice?
Maciej Stachowiak
Comment 2 2006-05-17 13:54:15 PDT
Comment on attachment 8368 [details] Add [Custom] keyword and port JSCanvasRenderingContext2D over to it r=me
Note You need to log in before you can comment on or make changes to this bug.