Bug 89566

Summary: [Gtk] Add gudev as a WebKitGTK+ dependency to the jhbuild module
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cgarcia, gustavo, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87503    
Attachments:
Description Flags
Patch none

Zan Dobersek
Reported 2012-06-20 06:31:35 PDT
[Gtk] Add gudev as a WebKitGTK+ dependency to the jhbuild module
Attachments
Patch (2.16 KB, patch)
2012-06-20 06:32 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2012-06-20 06:32:54 PDT
Created attachment 148553 [details] Patch
Zan Dobersek
Comment 2 2012-06-20 06:36:32 PDT
Here's the patch. The (g)udev version used is 175, the same that is present in Debian Wheezy. Fedora 17 seems to ship with the 182 version, but I think 175 suffices for now.
Gustavo Noronha (kov)
Comment 3 2012-06-20 06:58:21 PDT
Comment on attachment 148553 [details] Patch Attachment 148553 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13003197
Zan Dobersek
Comment 4 2012-06-20 08:55:27 PDT
(In reply to comment #3) > (From update of attachment 148553 [details]) > Attachment 148553 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/13003197 I'm not really sure this error has some proper meaning. The compilation of gudev runs fine locally for me, and the output doesn't really indicate what went wrong.
Philippe Normand
Comment 5 2012-06-20 13:20:48 PDT
Is gudev really needed in jhbuild? I understand it's required for the gamepad stuff but maybe we can simply make sure it's installed on the bots?
Carlos Garcia Campos
Comment 6 2012-06-20 23:45:25 PDT
(In reply to comment #5) > Is gudev really needed in jhbuild? I understand it's required for the gamepad stuff but maybe we can simply make sure it's installed on the bots? I don't know, I thought that adding it to the jhbuild was a way to make sure it's installed in the bots, but I don't mind if it's installed from the packages, gudev won't affect the test layout results anyway.
Zan Dobersek
Comment 7 2012-06-22 11:03:42 PDT
(In reply to comment #6) > (In reply to comment #5) > > Is gudev really needed in jhbuild? I understand it's required for the gamepad stuff but maybe we can simply make sure it's installed on the bots? > > I don't know, I thought that adding it to the jhbuild was a way to make sure it's installed in the bots, but I don't mind if it's installed from the packages, gudev won't affect the test layout results anyway. Either way is fine by me, but who do I bug to get the dependency installed on the bots? :>
Zan Dobersek
Comment 8 2012-06-25 09:22:46 PDT
gudev was installed throughout the bots.
Note You need to log in before you can comment on or make changes to this bug.