Bug 89540 – Teach the Apple port how to build the test tools in build-webkit

• Component: Tools / Tests
• Status: CLOSED FIXED

[Lucas Forschler]

Currently, build-webkit does not build the test tools for the Apple port.  
Teach it.

[Lucas Forschler]

Created attachment 148482 [details]
patch to teach build-webkit how to build tools

I've tested this on Lion for release and debug.  Testing windows now.

[Lucas Forschler]

I'll look into windows more tomorrow.  It looks like i missed updating paths for two of the projects.

push @projects, ("Tools/DumpRenderTree", "Tools/WebKitTestRunner", "Tools/TestWebKitAPI");

[WebKit Review Bot]

Comment on attachment 148482 [details]
patch to teach build-webkit how to build tools

Attachment 148482 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13005081

New failing tests:
platform/chromium/compositing/layout-width-change.html
platform/chromium/compositing/render-surface-alpha-blending.html
platform/chromium/compositing/tiny-layer-rotated.html
platform/chromium/compositing/huge-layer-rotated.html
fast/loader/loadInProgress.html
platform/chromium/compositing/3d-corners.html
platform/chromium/compositing/video-frame-size-change.html
platform/chromium/compositing/perpendicular-layer-sorting.html
fast/loader/unload-form-post-about-blank.html
platform/chromium/compositing/child-layer-3d-sorting.html
platform/chromium/compositing/accelerated-drawing/svg-filters.html
platform/chromium/compositing/lost-compositor-context-permanently.html
platform/chromium/compositing/filters/background-filter-blur-outsets.html
platform/chromium/compositing/lost-compositor-context-with-video.html
platform/chromium/compositing/accelerated-drawing/alpha.html
http/tests/xmlhttprequest/zero-length-response.html
http/tests/security/script-crossorigin-loads-correctly.html
fast/repaint/block-selection-gap-in-composited-layer.html
platform/chromium/compositing/webgl-loses-compositor-context.html
platform/chromium/compositing/backface-visibility-transformed.html
platform/chromium/compositing/lost-compositor-context-with-rendersurface.html
platform/chromium/compositing/lost-compositor-context.html
platform/chromium/compositing/img-layer-grow.html
platform/chromium/compositing/filters/background-filter-blur-off-axis.html
platform/chromium/compositing/filters/background-filter-blur.html
platform/chromium/compositing/lost-compositor-context-twice.html

[WebKit Review Bot]

Created attachment 148498 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Build Bot]

Comment on attachment 148482 [details]
patch to teach build-webkit how to build tools

Attachment 148482 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13000287

[Lucas Forschler]

Created attachment 148692 [details]
updated patch which should turn on tools building for apple ports, and update the b.w.o steps to pass along --no-build when running.

updated patch

[Build Bot]

Comment on attachment 148692 [details]
updated patch which should turn on tools building for apple ports, and update the b.w.o steps to pass along --no-build when running.

Attachment 148692 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13039004

[Simon Fraser (smfr)]

The build errors are:
gtest-port.h:831: error: cannot use typeid with -fno-rtti

which suggests that when we build gtest there's some issue with compiler settings or something.

Did you try building Release?

[Lucas Forschler]

I build release clean, and debug clean on my local machine.  I wonder if the EWS bots need to have their xcode version updated?

[Lucas Forschler]

Created attachment 149336 [details]
patch to teach apple bots to build tools

fix typo

[Jon Lee]

Comment on attachment 149336 [details]
patch to teach apple bots to build tools

View in context: https://bugs.webkit.org/attachment.cgi?id=149336&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:420
> +        if platform.startswith('mac')':

Another apostrophe to be wiped out...

[Lucas Forschler]

Created attachment 149341 [details]
teach apple bots new tricks.

fix again

[Build Bot]

Comment on attachment 149341 [details]
teach apple bots new tricks.

Attachment 149341 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13096218

[Ryosuke Niwa]

I'm confused. The patch has been landed on http://trac.webkit.org/changeset/121302/, but this bug isn't closed. Also, I'm hitting the same build failure EWS bot was encountering.

[Simon Fraser (smfr)]

What xcode version do you have?

[Mark Rowe (bdash)]

The build failure appears to be due to an incompatibility between gtest and llvm-gcc-4.2 (gtest doesn't know how to detect RTTI so it simply assumes it is on). You can work around this issue by upgrading to a newer version of Xcode, where clang will be used instead of llvm-gcc. I'd have expected this to have been addressed before the patch was checked in though.

[Ryosuke Niwa]

(In reply to comment #15)
> What xcode version do you have?

3.2.6.

[Mark Rowe (bdash)]

You'll run in to that error in debug builds for any Xcode version prior to 4.1, and in release builds for any Xcode version prior to 4.2.

[Ryosuke Niwa]

See https://bugs.webkit.org/show_bug.cgi?id=90055 for the build fix.

[Simon Fraser (smfr)]

I filed 90090 to have the scripts check your tools versions.

[Lucas Forschler]

closing bug.  bots appear to be working.