Summary: | [Chromium] IndexedDB: Don't close database if pending connections are in flight | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joshua Bell <jsbell> | ||||||
Component: | WebCore Misc. | Assignee: | Joshua Bell <jsbell> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, dgrogan, tony, vsevik, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Joshua Bell
2012-06-19 13:59:49 PDT
Created attachment 148432 [details]
Patch
+vsevik@ for the inspector changes. This patch requires that the second phase of database connections is processed. tony@ can you take a look? Comment on attachment 148432 [details]
Patch
LGTM
dgrogan@, can you take a look too since we were discussing this and how it would relate to your upcoming patch? Comment on attachment 148432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148432&action=review LGTM > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:347 > + RefPtr<IDBDatabaseBackendImpl> self = this; What scenario does this prevent? I didn't look at the inspector part at all. Comment on attachment 148432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148432&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:347 >> + RefPtr<IDBDatabaseBackendImpl> self = this; > > What scenario does this prevent? Whoops, good catch. That's just residue from early debugging. Created attachment 148474 [details]
Patch for landing
Comment on attachment 148474 [details] Patch for landing Clearing flags on attachment: 148474 Committed r120828: <http://trac.webkit.org/changeset/120828> All reviewed patches have been landed. Closing bug. |