Summary: | [Chromium] Remove redundant #includes in compositor | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zlieber | ||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cc-bugs, eric.carlson, feature-media-reviews, jamesr, kbr, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zlieber
2012-06-19 13:03:27 PDT
Created attachment 148400 [details]
Patch
Comment on attachment 148400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148400&action=review > Source/WebCore/ChangeLog:10 > + Removed some redundant #include's to clarify dependency > + picture. Some 90 #include's removed, some 50 less disruptive > + #include's added. This brings the number of class dependencies to grammar: s/'//g. No grocers' apostrophes. ;) > Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.h:39 > +#include "Path.h" Forward declare this instead. > Source/WebCore/platform/graphics/chromium/RenderSurfaceChromium.h:32 > +#include "Color.h" What is this doing? > Source/WebCore/platform/graphics/chromium/cc/CCRenderer.h:44 > +enum TextureUploaderOption { ThrottledUploader, UnthrottledUploader }; > + I think this is an LRC detail, not a CCRenderer one. Created attachment 148418 [details]
Patch
Comment on attachment 148418 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148418&action=review R=me. Moving the TextureUploaderOption makes sense given the CCLTHI layer renderer creation method. Maybe that can get cleaned up after we have a real software renderer implementation. Thanks for all this cleanup. It's obviously needed! > Source/WebCore/ChangeLog:3 > + [Chromium] Remove redundant #include's in compositor ಠ_ಠ (In reply to comment #4) > (From update of attachment 148418 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148418&action=review > > R=me. Moving the TextureUploaderOption makes sense given the CCLTHI layer renderer creation method. Maybe that can get cleaned up after we have a real software renderer implementation. > > Thanks for all this cleanup. It's obviously needed! > > > Source/WebCore/ChangeLog:3 > > + [Chromium] Remove redundant #include's in compositor > > ಠ_ಠ Arghh!! missed that one Created attachment 148430 [details]
Patch
Comment on attachment 148430 [details] Patch Clearing flags on attachment: 148430 Committed r120772: <http://trac.webkit.org/changeset/120772> All reviewed patches have been landed. Closing bug. Reverted r120772 for reason: Broke build on Chromium Mac Committed r120775: <http://trac.webkit.org/changeset/120775> Sorry, I had to roll this out as it broke the build. Sample failure: http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/38407/steps/compile-webkit/logs/stdio Looks simple to fix -- change of a forward declaration from class to struct. Created attachment 148469 [details]
Patch
Comment on attachment 148469 [details] Patch Clearing flags on attachment: 148469 Committed r120820: <http://trac.webkit.org/changeset/120820> All reviewed patches have been landed. Closing bug. |