Bug 89473
| Summary: | [Qt][WK2] editing/pasteboard/copy-in-password-field.html fails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | abrhm, ossy, zarvai |
| Priority: | P2 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Csaba Osztrogonác
editing/pasteboard/copy-in-password-field.html fails on Qt-WK2 bots.
(It passed when xvfbdriver was enabled.)
--- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/editing/pasteboard/copy-in-password-field-expected.txt
+++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/editing/pasteboard/copy-in-password-field-actual.txt
@@ -3,9 +3,9 @@
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldInsertText:[not modified] replacingDOMRange:range from 0 of #text > DIV > #shadow-root to 14 of #text > DIV > #shadow-root givenAction:WebViewInsertActionPasted
+EDITING DELEGATE: shouldInsertText: replacingDOMRange:range from 0 of #text > DIV > #shadow-root to 14 of #text > DIV > #shadow-root givenAction:WebViewInsertActionPasted
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root toDOMRange:range from 14 of #text > DIV > #shadow-root to 14 of #text > DIV > #shadow-root affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
+EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root toDOMRange:range from 0 of DIV > #shadow-root to 0 of DIV > #shadow-root affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
This test verifies that copying is disabled for password fields by attempting to copy from a password field and paste into a textfield. If the test passes, you'll see a of 'PASS' message below, and the textfield will remain unmodified.
@@ -13,5 +13,5 @@
(The test is only meaningful in debug builds, since paste is disabled in release builds.)
-PASS document.getElementById("text").value is "[not modified]"
+FAIL document.getElementById("text").value should be [not modified]. Was .
I tried to reproduce it locally, but I can't when I run only this test or all editing or all editing/pasteboard tests.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
I skipped it to try to paint the bots green - http://trac.webkit.org/changeset/120715
Csaba Osztrogonác
Great ... after skipping editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html started to fail ...
It is before editing/pasteboard/copy-in-password-field.html ...
but it was "only" flakey (IMAGE PASS) previously. But after skipping
editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html
it started to fail constantly. Let's skip it too, because less tests means less problem. :)
Csaba Osztrogonác
(In reply to comment #2)
> Great ... after skipping editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html started to fail ...
>
> It is before editing/pasteboard/copy-in-password-field.html ...
> but it was "only" flakey (IMAGE PASS) previously. But after skipping
> editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html
> it started to fail constantly. Let's skip it too, because less tests means less problem. :)
editing/pasteboard/copy-element-with-conflicting-background-color-from-rule.html skipped in http://trac.webkit.org/changeset/120720
Gábor Ábrahám
Now this test passed.
https://trac.webkit.org/changeset/150892