Bug 89472

Summary:

Web Inspector: other section of the native memory chart sometimes contain negative value

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Alexei Filippov <alph>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Screenshot	none
Test page	none
Patch	yurys: review-

Yury Semikhatsky

Reported 2012-06-19 08:05:16 PDT

See attached screenshot. Steps to reproduce: 1. Open attached file. 2. Open the native memory bar chart. 3. Refresh inspected page several times.

Attachments
Screenshot (134.91 KB, image/png) 2012-06-19 08:05 PDT, Yury Semikhatsky	no flags	Details
Test page (170 bytes, text/html) 2012-06-19 08:06 PDT, Yury Semikhatsky	no flags	Details
Patch (2.99 KB, patch) 2012-06-21 06:31 PDT, Alexei Filippov	yurys: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-06-19 08:05:47 PDT

Created attachment 148336 [details] Screenshot

Yury Semikhatsky

Comment 2 2012-06-19 08:06:28 PDT

Created attachment 148337 [details] Test page

Alexei Filippov

Comment 3 2012-06-21 05:53:19 PDT

Seems to be a v8 issue. I filed a bug http://code.google.com/p/v8/issues/detail?id=2191 But we can kinda workaround it.

Alexei Filippov

Comment 4 2012-06-21 06:31:44 PDT

Created attachment 148782 [details] Patch

Yury Semikhatsky

Comment 5 2012-06-21 07:29:16 PDT

Comment on attachment 148782 [details] Patch This is a new feature so let's get backend to report correct size instead.

Alexei Filippov

Comment 6 2012-06-21 07:37:15 PDT

I think it might still be an issue on our side. Assuming that sizes of different components are taken a [slightly] different time moments, it might happen that process memory size were reported before a big allocation attributed to a component occurred and its new size reported.

Yury Semikhatsky

Comment 7 2012-06-21 07:42:14 PDT

(In reply to comment #6) > I think it might still be an issue on our side. Assuming that sizes of different components are taken a [slightly] different time moments, it might happen that process memory size were reported before a big allocation attributed to a component occurred and its new size reported. We take memory snapshot synchronously and there shouldn't be such big differences and even if we observe ones how can we tell if it the total reported size is wrong or a sum of partitions having incorrect size is incorrect?

Alexei Filippov

Comment 8 2012-06-21 07:50:01 PDT

(In reply to comment #7) > (In reply to comment #6) > > I think it might still be an issue on our side. Assuming that sizes of different components are taken a [slightly] different time moments, it might happen that process memory size were reported before a big allocation attributed to a component occurred and its new size reported. > > We take memory snapshot synchronously and there shouldn't be such big differences and even if we observe ones how can we tell if it the total reported size is wrong or a sum of partitions having incorrect size is incorrect? Yes, we do it synchronously, but is the renderer process single threaded? Regarding what component is incorrect. It's not really incorrect, it's rather a bit outdated (if we're talking about the scenario I described above), so reporting either is ok. Taking into account I cannot determine which component size is updated it's easier to just update the total.

Brian Burg

Comment 9 2014-12-12 14:35:57 PST

Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (https://www.webkit.org/new-inspector-bug) if the bug/feature/issue is still relevant to WebKit trunk.

Note You need to log in before you can comment on or make changes to this bug.