Bug 8940

Summary: remove extra copy of image code
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, hyatt
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to remove code from both WebKit and WebCore andersca: review+

Darin Adler
Reported 2006-05-16 09:26:28 PDT
I started removing the extra image code. For all I know Anders already started doing this, but I couldn't help myself!
Attachments
patch to remove code from both WebKit and WebCore (159.70 KB, patch)
2006-05-16 10:01 PDT, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2006-05-16 09:56:42 PDT
How far along are you with this? I'm working on it right now and I'm almost finished (I think)
Darin Adler
Comment 2 2006-05-16 10:01:58 PDT
Created attachment 8351 [details] patch to remove code from both WebKit and WebCore
Anders Carlsson
Comment 3 2006-05-16 10:12:31 PDT
Comment on attachment 8351 [details] patch to remove code from both WebKit and WebCore Looks like the way I did it, except for one thing: I used ForElement in _web_declareAndWriteDragImageElement and _web_dragImageElement, as per John's suggestion. Feel free to change that if you want.
Darin Adler
Comment 4 2006-05-16 11:40:42 PDT
Darn. I should have waiting. Didn't realize you were so far along!
Darin Adler
Comment 5 2006-05-16 13:12:42 PDT
(In reply to comment #3) > I used ForElement in _web_declareAndWriteDragImageElement and > _web_dragImageElement, as per John's suggestion. OK. I'll do that.
Darin Adler
Comment 6 2006-05-16 15:22:26 PDT
Committed revision 14420.
Darin Adler
Comment 7 2006-05-16 15:23:33 PDT
Committed revision 14421.
Note You need to log in before you can comment on or make changes to this bug.