Bug 89396 – Show TOT revision in garden-o-matic, and make the revisions into links

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Show TOT revision in garden-o-matic, and make the revisions into links

[Simon Fraser (smfr)]

Created attachment 148192 [details]
Patch

[Adam Barth]

Comment on attachment 148192 [details]
Patch

Please don't use string concatentation to build DOM.

[Adam Barth]

Comment on attachment 148192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148192&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:87
> -        this._what.textContent = message;
> +        this._what.innerHTML = message;

We don't use innerHTML in garden-o-matic because it leads to XSS.

[Dirk Pranke]

See, I knew I shouldn't be reviewing js-side changes :(.

[Simon Fraser (smfr)]

Created attachment 148213 [details]
Patch

[Adam Barth]

Comment on attachment 148213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148213&action=review

Thanks.  Sorry about the overhead of the (lame) HTML-based unit tests.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:85
> +            function markupForRevision(revision)
> +            {
> +                return '<a href=' + trac.changesetURL(revision) + '>' + revision + '</a>';
> +            }

This function seems unused now.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:91
> +        // this._what.removeAllChildren();

Please remove commented out code.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/120648