New inspector/styles/inject-stylesheet.html fails

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

This test introdeuced in http://trac.webkit.org/changeset/120600 
and fails at least on Qt and on Apple Mac Lion:


--- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/styles/inject-stylesheet-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/styles/inject-stylesheet-actual.txt 
@@ -1,82 +1,4 @@
-CONSOLE MESSAGE: line 9: iframe loaded
 Tests that injected user stylesheets are reflected in the Styles pane.
 
+This test requires window.testRunner, exiting.
 
-Main frame style:
-[expanded] 
-
-[expanded] 
-element.style  { ()
-
-======== Matched CSS Rules ========
-[expanded] 
-media="screen" (inject-stylesheet.html)
-#main  { (inject-stylesheet.html:5)
-background: blue;
-    background-image: initial;
-    background-repeat-x: initial;
-    background-repeat-y: initial;
-    background-attachment: initial;
-    background-position-x: initial;
-    background-position-y: initial;
-    background-origin: initial;
-    background-clip: initial;
-    background-color: blue;
-    background-size: initial;
-
-[expanded] 
-#main  { (user stylesheet)
-color: red;
-
-[expanded] 
-div  { (user agent stylesheet)
-display: block;
-
-
-iframe style:
-[expanded] 
-
-[expanded] 
-element.style  { ()
-
-======== Matched CSS Rules ========
-[expanded] 
-#iframebody  { (user stylesheet)
-background: red;
-    background-image: initial;
-    background-repeat-x: initial;
-    background-repeat-y: initial;
-    background-attachment: initial;
-    background-position-x: initial;
-    background-position-y: initial;
-    background-origin: initial;
-    background-clip: initial;
-    background-color: red;
-    background-size: initial;
-
-[expanded] 
-media="screen" (inject-stylesheet-iframe-data.html)
-body  { (inject-stylesheet-iframe-data.html:4)
-background: green;
-    /-- overloaded --/ background-image: initial;
-    /-- overloaded --/ background-repeat-x: initial;
-    /-- overloaded --/ background-repeat-y: initial;
-    /-- overloaded --/ background-attachment: initial;
-    /-- overloaded --/ background-position-x: initial;
-    /-- overloaded --/ background-position-y: initial;
-    /-- overloaded --/ background-origin: initial;
-    /-- overloaded --/ background-clip: initial;
-    /-- overloaded --/ background-color: green;
-    /-- overloaded --/ background-size: initial;
-
-[expanded] 
-body  { (user agent stylesheet)
-display: block;
-margin: 8px;
-    margin-top: 8px;
-    margin-right: 8px;
-    margin-bottom: 8px;
-    margin-left: 8px;
-
-
-

[Csaba Osztrogonác]

I skipped it on Qt - r120610 to paint the bot green.
Please unskip it with the proper fix.

[Alexander Pavlov (apavlov)]

Created attachment 148321 [details]
Patch

[Csaba Osztrogonác]

I don't know inspector, so I'm not the best person for review. Maybe Zoltán?

Otherwise I tested the patch and LayoutTests/inspector/styles/inject-stylesheet.html passes on Qt with it.

[Zoltan Herczeg]

Comment on attachment 148321 [details]
Patch

LGTM

[Alexander Pavlov (apavlov)]

Committed r120708: <http://trac.webkit.org/changeset/120708>